From: Jiri Kosina <jkosina@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers
Date: Wed, 10 Sep 2014 17:28:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1409101725340.5523@pobox.suse.cz> (raw)
In-Reply-To: <20140910152104.GS6549@mwanda>
On Wed, 10 Sep 2014, Dan Carpenter wrote:
> > BTW if we stretch this argument a little bit more, we should also kill the
> > ZERO_OR_NULL_PTR() check from kfree() and make it callers responsibility
> > to perform the checking only if applicable ... we are currently doing a
> > lot of pointless checking in cases where caller would be able to guarantee
> > that the pointer is going to be non-NULL.
>
> What you're saying is that we should remove the ZERO_SIZE_PTR
> completely. ZERO_SIZE_PTR is a very useful idiom and also it's too late
> to remove it because everything depends on it.
I was just argumenting that if we care about single additional test in
this path, the ZERO_OR_NULL_PTR() should have never been added at the
first place, and the responsibility for checking should have been kept at
callers.
Too late for this now, yes.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-10 15:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:25 Jiri Kosina
2014-09-09 23:21 ` Andrew Morton
2014-09-10 5:05 ` Jiri Kosina
2014-09-10 5:11 ` Andrew Morton
2014-09-10 6:36 ` Dan Carpenter
2014-09-10 13:56 ` Theodore Ts'o
2014-09-10 14:27 ` Dave Jones
2014-09-10 14:07 ` Theodore Ts'o
2014-09-10 14:24 ` Jiri Kosina
2014-09-10 14:33 ` Andrey Ryabinin
2014-09-10 14:42 ` Jiri Kosina
2014-09-10 15:43 ` Christoph Lameter
2014-09-10 14:26 ` Jiri Kosina
2014-09-10 15:21 ` Dan Carpenter
2014-09-10 15:28 ` Jiri Kosina [this message]
2014-09-10 15:53 ` Dan Carpenter
2014-09-10 19:40 ` Theodore Ts'o
2014-09-11 14:14 ` Rasmus Villemoes
2014-09-10 14:22 ` Christoph Lameter
2014-09-10 5:15 ` Valdis.Kletnieks
2014-09-10 6:51 ` Dan Carpenter
2014-09-10 13:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1409101725340.5523@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.carpenter@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox