From: Hugh Dickins <hughd@google.com>
To: Petr Holasek <pholasek@redhat.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
Mel Gorman <mgorman@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] ksm: make rmap walks more scalable
Date: Thu, 20 Dec 2012 18:35:50 -0800 (PST) [thread overview]
Message-ID: <alpine.LNX.2.00.1212201830020.28881@eggly.anvils> (raw)
In-Reply-To: <20121221003648.GA9649@thinkpad-work.redhat.com>
On Fri, 21 Dec 2012, Petr Holasek wrote:
> On Thu, 20 Dec 2012, Sasha Levin wrote:
> > On 12/20/2012 05:37 PM, Hugh Dickins wrote:
> > >
> > > To stop these oopses in get_mergeable_page (inlined in
> > > unstable_tree_search_insert) you need the patch I showed on
> > > Tuesday, which I hope he'll merge in for his v6. That doesn't fix
> > > all of the problems, but hopefully all that you'll encounter before
> > > I've devised a fix for the separate stale stable_nodes issue.
> >
> > My bad! I thought that this is the finalized version of the patch from
> > Tuesday and was surprised when the oops was still there :)
> >
> > fwiw I'll use this to report that I'm not seeing any unexpected behaviour
> > with this patch applied.
Thanks, Sasha.
>
> Hugh, big thanks for your Tuesday fix, I am not able to reproduce reported
> oops any more. I will continue with testing overnight and submit v6 version
> tomorrow if there won't be any problem.
Great, thank you Petr.
>
> Should I also add [PATCH] ksm: make rmap walks more scalable into v6 or
> can I rely on it?
No, this rmap walks patch is entirely independent of your changes,
and already picked up by Linus into his tree for rc1.
By all means test with it in, or out, but don't fold it into your v6:
Andrew's mmotm posted just now has it already in too.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-21 2:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 1:42 [PATCH] sched: numa: ksm: fix oops in task_numa_placment() Hugh Dickins
2012-12-20 1:44 ` [PATCH] ksm: make rmap walks more scalable Hugh Dickins
2012-12-20 11:17 ` Mel Gorman
2012-12-20 21:49 ` Sasha Levin
2012-12-20 22:26 ` Linus Torvalds
2012-12-20 22:40 ` Hugh Dickins
2012-12-20 22:37 ` Hugh Dickins
2012-12-20 22:43 ` Sasha Levin
2012-12-21 0:36 ` Petr Holasek
2012-12-21 2:35 ` Hugh Dickins [this message]
2012-12-20 11:14 ` [PATCH] sched: numa: ksm: fix oops in task_numa_placment() Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1212201830020.28881@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pholasek@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox