From: Hugh Dickins <hughd@google.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>, Zheng Liu <wenqing.lz@taobao.com>,
Jeff liu <jeff.liu@oracle.com>, Jim Meyering <jim@meyering.net>,
Paul Eggert <eggert@cs.ucla.edu>,
Christoph Hellwig <hch@infradead.org>,
Josef Bacik <josef@redhat.com>, Andi Kleen <andi@firstfloor.org>,
Andreas Dilger <adilger@dilger.ca>,
Marco Stornelli <marco.stornelli@gmail.com>,
Chris Mason <chris.mason@fusionio.com>,
Sunil Mushran <sunil.mushran@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)
Date: Wed, 28 Nov 2012 20:22:09 -0800 (PST) [thread overview]
Message-ID: <alpine.LNX.2.00.1211282011120.972@eggly.anvils> (raw)
In-Reply-To: <20121129024446.GY6434@dastard>
On Thu, 29 Nov 2012, Dave Chinner wrote:
> On Wed, Nov 28, 2012 at 05:22:03PM -0800, Hugh Dickins wrote:
> > Revert 3.5's f21f8062201f ("tmpfs: revert SEEK_DATA and SEEK_HOLE")
> > to reinstate 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE"),
> > with the intervening additional arg to generic_file_llseek_size().
> >
> > In 3.8, ext4 is expected to join btrfs, ocfs2 and xfs with proper
> > SEEK_DATA and SEEK_HOLE support; and a good case has now been made
> > for it on tmpfs, so let's join the party.
> >
> > It's quite easy for tmpfs to scan the radix_tree to support llseek's new
> > SEEK_DATA and SEEK_HOLE options: so add them while the minutiae are still
> > on my mind (in particular, the !PageUptodate-ness of pages fallocated but
> > still unwritten).
> >
> > [akpm@linux-foundation.org: fix warning with CONFIG_TMPFS=n]
> > Signed-off-by: Hugh Dickins <hughd@google.com>
> > ---
>
> Does it pass the seek hole/data tests (285, 286) in xfstests?
It did before and ... [install this, install that, install tother]
... yes, it still passes those tests - using Boris Ranto's patch
extending xfstests to include tmpfs.
Though I'd have even more confidence if they gave a little pat on
the back for doing better than the no-op default, which also passes.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-29 4:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 1:22 Hugh Dickins
2012-11-29 1:29 ` Jaegeuk Hanse
2012-11-29 2:02 ` Hugh Dickins
2012-11-29 4:15 ` Jim Meyering
2012-11-29 4:42 ` Jeff Liu
2012-11-29 6:53 ` Jim Meyering
2012-11-29 7:27 ` Jeff Liu
2012-11-29 19:52 ` Dave Chinner
2012-11-29 20:17 ` Jim Meyering
2012-11-29 2:44 ` Dave Chinner
2012-11-29 4:22 ` Hugh Dickins [this message]
2012-11-29 22:59 ` Andrew Morton
2012-11-29 23:29 ` Hugh Dickins
2012-11-30 0:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1211282011120.972@eggly.anvils \
--to=hughd@google.com \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=chris.mason@fusionio.com \
--cc=david@fromorbit.com \
--cc=eggert@cs.ucla.edu \
--cc=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=jim@meyering.net \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marco.stornelli@gmail.com \
--cc=sunil.mushran@oracle.com \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox