From: Jesper Juhl <jj@chaosbits.net>
To: Michel Lespinasse <walken@google.com>
Cc: x86@kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <hannes@cmpxchg.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] Use 'do {} while (0)' for empty flush_tlb_fix_spurious_fault() macro
Date: Sun, 18 Dec 2011 02:00:31 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1112180158330.21784@swampdragon.chaosbits.net> (raw)
In-Reply-To: <CANN689GQyzMGfnxsKmni7wDFpqo4s=D3dpu6w9UxN0tKbqakig@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1075 bytes --]
On Sat, 17 Dec 2011, Michel Lespinasse wrote:
> On Sat, Dec 17, 2011 at 4:32 PM, Jesper Juhl <jj@chaosbits.net> wrote:
> > If one builds the kernel with -Wempty-body one gets this warning:
> >
> > mm/memory.c:3432:46: warning: suggest braces around empty body in an ?if? statement [-Wempty-body]
> >
> > due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
> > can sometimes be defined to nothing.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Looks good to me. I'd be happy with either that or Al's alternative suggestion.
>
> Reviewed-by: Michel Lespinasse <walken@google.com>
>
Thanks for the review.
I did see Al's suggestion and he does have a point. But since it doesn't
actually matter much in this specific case I'd say "let's just go with
this one - it matches what's done nearly everywhere else".
But, If someone disagrees strongly I'll cook up a different patch. :-)
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
prev parent reply other threads:[~2011-12-18 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 0:32 Jesper Juhl
2011-12-18 0:43 ` Michel Lespinasse
2011-12-18 1:00 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1112180158330.21784@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
--cc=walken@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox