From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx113.postini.com [74.125.245.113]) by kanga.kvack.org (Postfix) with SMTP id 370BE6B004F for ; Sat, 17 Dec 2011 19:26:39 -0500 (EST) Date: Sun, 18 Dec 2011 01:26:37 +0100 (CET) From: Jesper Juhl Subject: Re: [PATCH] Put braces around potentially empty 'if' body in handle_pte_fault() In-Reply-To: <1324167535.3323.63.camel@edumazet-laptop> Message-ID: References: <1324167535.3323.63.camel@edumazet-laptop> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1228915649-1324167997=:21784" Sender: owner-linux-mm@kvack.org List-ID: To: Eric Dumazet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Michel Lespinasse , Hugh Dickins , Andrea Arcangeli , KAMEZAWA Hiroyuki This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1228915649-1324167997=:21784 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 18 Dec 2011, Eric Dumazet wrote: > Le dimanche 18 dA(C)cembre 2011 A 01:03 +0100, Jesper Juhl a A(C)crit : > > If one builds the kernel with -Wempty-body one gets this warning: > > > > mm/memory.c:3432:46: warning: suggest braces around empty body in an a??ifa?? statement [-Wempty-body] > > > > due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that > > can sometimes be defined to nothing. > > > > I suggest we heed gcc's advice and put a pair of braces on that if. > > > > Signed-off-by: Jesper Juhl > > --- > > mm/memory.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 829d437..9cf1b48 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm, > > * This still avoids useless tlb flushes for .text page faults > > * with threads. > > */ > > - if (flags & FAULT_FLAG_WRITE) > > + if (flags & FAULT_FLAG_WRITE) { > > flush_tlb_fix_spurious_fault(vma, address); > > + } > > } > > unlock: > > pte_unmap_unlock(pte, ptl); > > -- > > 1.7.8 > > > > Thats should be fixed in the reverse way : > > #define flush_tlb_fix_spurious_fault(vma, address) do { } while (0) > I did consider that, bot opted for the other solution since there was only one user. But, on second thought, you are right, I should just have made the macro safe so that future uses also won't have problems. Will send a new patch in a minute. -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. --8323328-1228915649-1324167997=:21784-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org