From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx206.postini.com [74.125.245.206]) by kanga.kvack.org (Postfix) with SMTP id DEFED6B004F for ; Sat, 17 Dec 2011 19:03:08 -0500 (EST) Date: Sun, 18 Dec 2011 01:03:06 +0100 (CET) From: Jesper Juhl Subject: [PATCH] Put braces around potentially empty 'if' body in handle_pte_fault() Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-457409574-1324166586=:21784" Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , Michel Lespinasse , Hugh Dickins , Andrea Arcangeli , KAMEZAWA Hiroyuki This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-457409574-1324166586=:21784 Content-Type: TEXT/PLAIN; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT If one builds the kernel with -Wempty-body one gets this warning: mm/memory.c:3432:46: warning: suggest braces around empty body in an !ifc statement [-Wempty-body] due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that can sometimes be defined to nothing. I suggest we heed gcc's advice and put a pair of braces on that if. Signed-off-by: Jesper Juhl --- mm/memory.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 829d437..9cf1b48 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm, * This still avoids useless tlb flushes for .text page faults * with threads. */ - if (flags & FAULT_FLAG_WRITE) + if (flags & FAULT_FLAG_WRITE) { flush_tlb_fix_spurious_fault(vma, address); + } } unlock: pte_unmap_unlock(pte, ptl); -- 1.7.8 -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. --8323328-457409574-1324166586=:21784-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org