From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 06C198D003B for ; Sat, 5 Mar 2011 14:44:48 -0500 (EST) Date: Sat, 5 Mar 2011 20:44:14 +0100 (CET) From: Jesper Juhl Subject: Re: [PATCHv2 15/24] sys_swapon: move setting of swapfilepages near use In-Reply-To: <1299343345-3984-16-git-send-email-cesarb@cesarb.net> Message-ID: References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-16-git-send-email-cesarb@cesarb.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote: > There is no reason I can see to read inode->i_size long before it is > needed. Move its read to just before it is needed, to reduce the > variable lifetime. > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson This will save us having to do the assignment in many cases where we jump to one of the labels at the end uf the function before using the 'swapfilepages' variable. Looks good to me. Reviewed-by: Jesper Juhl -- Jesper Juhl http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org