From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 6117F8D0039 for ; Sat, 5 Mar 2011 14:12:05 -0500 (EST) Date: Sat, 5 Mar 2011 20:11:29 +0100 (CET) From: Jesper Juhl Subject: Re: [PATCHv2 02/24] sys_swapon: remove changelog from function comment In-Reply-To: <1299343345-3984-3-git-send-email-cesarb@cesarb.net> Message-ID: References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-3-git-send-email-cesarb@cesarb.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote: > Changelogs belong in the git history instead of in the source code. > > Also, "The swapon system call" is redundant with > "SYSCALL_DEFINE2(swapon, ...)". > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson > --- > mm/swapfile.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 3fe8913..75ee39c 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1844,11 +1844,6 @@ static int __init max_swapfiles_check(void) > late_initcall(max_swapfiles_check); > #endif > > -/* > - * Written 01/25/92 by Simmule Turner, heavily changed by Linus. > - * > - * The swapon system call > - */ Second line in the comment can hardly be called "changelog". Removing the comment won't break anything, so Reviewed-by: Jesper Juhl -- Jesper Juhl http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org