From: Jesper Juhl <jj@chaosbits.net>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Mel Gorman <mel@csn.ul.ie>, LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] cleanup kswapd()
Date: Sun, 14 Nov 2010 12:03:36 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1011141202430.3460@swampdragon.chaosbits.net> (raw)
In-Reply-To: <20101114180505.BEE2.A69D9226@jp.fujitsu.com>
On Sun, 14 Nov 2010, KOSAKI Motohiro wrote:
>
> Currently, kswapd() function has deeper nest and it slightly harder to
> read. cleanup it.
>
> Cc: Mel Gorman <mel@csn.ul.ie>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> ---
> mm/vmscan.c | 71 +++++++++++++++++++++++++++++++---------------------------
> 1 files changed, 38 insertions(+), 33 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 8cc90d5..82ffe5f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2364,6 +2364,42 @@ out:
> return sc.nr_reclaimed;
> }
>
> +void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
Shouldn't this be
static void kswapd_try_to_sleep(pg_data_t *pgdat, int order)
??
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-14 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 9:05 KOSAKI Motohiro
2010-11-14 11:03 ` Jesper Juhl [this message]
2010-11-15 0:27 ` KOSAKI Motohiro
2010-11-15 1:37 ` KOSAKI Motohiro
2010-11-15 9:42 ` Mel Gorman
2010-11-16 6:07 ` [PATCH v3] factor out kswapd sleeping logic from kswapd() KOSAKI Motohiro
2010-11-18 17:27 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1011141202430.3460@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox