From: Jan Engelhardt <jengelh@computergmbh.de>
To: Joe Perches <joe@perches.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Add definitions of USHRT_MAX
Date: Fri, 21 Mar 2008 03:12:49 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.1.00.0803210312400.10642@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <1206064278.26345.108.camel@localhost>
On Mar 20 2008 18:51, Joe Perches wrote:
> On Fri, 2008-03-21 at 09:40 +0800, Zhang, Yanmin wrote:
>> Add definitions of USHRT_MAX and others into kernel. ipc uses it and
>> slub implementation might also use it.
>> +#define USHRT_MAX ((u16)(~0U))
>> +#define SHRT_MAX ((s16)(USHRT_MAX>>1))
>> +#define SHRT_MIN (-SHRT_MAX - 1)
>
> Perhaps it's better to use the most common kernel types?
> Perhaps U16_MAX, S16_MAX and S16_MIN?
>
> Don't you need to cast SHRT_MIN/S16_MIN too?
> #define S16_MIN ((s16)(-SHRT_MAX - 1))
SHRT_MAX is already s16.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-03-21 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 1:40 Zhang, Yanmin
2008-03-21 1:51 ` Joe Perches
2008-03-21 2:08 ` Zhang, Yanmin
2008-03-21 2:12 ` Jan Engelhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0803210312400.10642@fbirervta.pbzchgretzou.qr \
--to=jengelh@computergmbh.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox