From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id F29916B0071 for ; Tue, 23 Nov 2010 19:15:00 -0500 (EST) Date: Wed, 24 Nov 2010 02:14:07 +0200 (EET) From: Mika Laitio Subject: Re: [PATCH -mmotm] w1: fix ds2423 build, needs to select CRC16 In-Reply-To: <20101117212517.48069281.randy.dunlap@oracle.com> Message-ID: References: <201011180135.oAI1Znl3017273@imap1.linux-foundation.org> <20101117212517.48069281.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Randy Dunlap Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org List-ID: Thanks for noticing the missing crc16 module selection, it's indeed needed if it's not for some other reason selected in the .config. Mika > From: Randy Dunlap > > Fix w1_ds2423 build: needs to select CRC16. > > w1_ds2423.c:(.text+0x9971d): undefined reference to `crc16' > w1_ds2423.c:(.text+0x9973a): undefined reference to `crc16' > > Signed-off-by: Randy Dunlap > Cc: Mika Laitio > --- > drivers/w1/slaves/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- mmotm-2010-1117-1703.orig/drivers/w1/slaves/Kconfig > +++ mmotm-2010-1117-1703/drivers/w1/slaves/Kconfig > @@ -18,6 +18,7 @@ config W1_SLAVE_SMEM > > config W1_SLAVE_DS2423 > tristate "Counter 1-wire device (DS2423)" > + select CRC16 > help > If you enable this you can read the counter values available > in the DS2423 chipset from the w1_slave file under the > -- Terveisin Mika -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org