From: Mika Laitio <lamikr@pilppa.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH -mmotm] w1: fix ds2423 build, needs to select CRC16
Date: Wed, 24 Nov 2010 02:14:07 +0200 (EET) [thread overview]
Message-ID: <alpine.LMD.2.00.1011240208470.24087@shogun.pilppa.org> (raw)
In-Reply-To: <20101117212517.48069281.randy.dunlap@oracle.com>
Thanks for noticing the missing crc16 module selection, it's indeed
needed if it's not for some other reason selected in the .config.
Mika
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix w1_ds2423 build: needs to select CRC16.
>
> w1_ds2423.c:(.text+0x9971d): undefined reference to `crc16'
> w1_ds2423.c:(.text+0x9973a): undefined reference to `crc16'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Mika Laitio <lamikr@pilppa.org>
> ---
> drivers/w1/slaves/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2010-1117-1703.orig/drivers/w1/slaves/Kconfig
> +++ mmotm-2010-1117-1703/drivers/w1/slaves/Kconfig
> @@ -18,6 +18,7 @@ config W1_SLAVE_SMEM
>
> config W1_SLAVE_DS2423
> tristate "Counter 1-wire device (DS2423)"
> + select CRC16
> help
> If you enable this you can read the counter values available
> in the DS2423 chipset from the w1_slave file under the
>
--
Terveisin Mika
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-11-24 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 1:03 mmotm 2010-11-17-17-03 uploaded akpm
2010-11-18 5:25 ` [PATCH -mmotm] w1: fix ds2423 build, needs to select CRC16 Randy Dunlap
2010-11-24 0:14 ` Mika Laitio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LMD.2.00.1011240208470.24087@shogun.pilppa.org \
--to=lamikr@pilppa.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox