From: Pekka Enberg <penberg@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Joonsoo Kim <js1304@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1,2/4 v2] slub: use __cmpxchg_double_slab() at interrupt disabled place
Date: Fri, 18 May 2012 12:31:37 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1205181231170.3899@tux.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1205171149050.8534@router.home>
On Thu, 17 May 2012, Christoph Lameter wrote:
> On Fri, 18 May 2012, Joonsoo Kim wrote:
>
> > get_freelist() is only called by __slab_alloc() with interrupt disabled,
> > so __cmpxchg_double_slab() is suitable.
> >
> > unfreeze_partials() is only called with interrupt disabled,
> > so __cmpxchg_double_slab() is suitable.
>
> Combine these sentences as well.
>
> Acked-by: Christoph Lameter <cl@linux.com>
You should add a comment on top of get_freelist() and unfreeze_partials()
that they now *require* interrupts to be disabled.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-18 9:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 15:47 [PATCH 0/4] slub: refactoring some code in slub Joonsoo Kim
2012-05-17 15:47 ` [PATCH 1/4] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab Joonsoo Kim
2012-05-17 15:47 ` [PATCH 2/4] slub: change cmpxchg_double_slab in unfreeze_partials " Joonsoo Kim
2012-05-17 15:47 ` [PATCH 3/4] slub: use __SetPageSlab function to set PG_slab flag Joonsoo Kim
2012-05-17 16:07 ` Christoph Lameter
2012-05-18 9:31 ` Pekka Enberg
2012-05-17 15:47 ` [PATCH 4/4] slub: refactoring unfreeze_partials() Joonsoo Kim
2012-05-17 18:30 ` Christoph Lameter
2012-05-18 13:11 ` JoonSoo Kim
2012-06-01 12:28 ` Joonsoo Kim
2012-06-01 15:57 ` Christoph Lameter
2012-05-17 16:08 ` [PATCH 0/4] slub: refactoring some code in slub Christoph Lameter
2012-05-17 16:34 ` JoonSoo Kim
2012-05-17 16:41 ` [PATCH 1,2/4 v2] slub: use __cmpxchg_double_slab() at interrupt disabled place Joonsoo Kim
2012-05-17 16:49 ` Christoph Lameter
2012-05-17 17:03 ` [PATCH 1,2/4 v3] " Joonsoo Kim
2012-05-18 9:31 ` Pekka Enberg [this message]
2012-05-18 13:01 ` [PATCH 1,2/4 v4] " Joonsoo Kim
2012-06-20 7:14 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1205181231170.3899@tux.localdomain \
--to=penberg@kernel.org \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox