linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] slub: remove unused argument of init_kmem_cache_node()
@ 2012-05-10 15:50 Joonsoo Kim
  2012-05-10 15:56 ` Christoph Lameter
  2012-05-15  6:26 ` David Rientjes
  0 siblings, 2 replies; 4+ messages in thread
From: Joonsoo Kim @ 2012-05-10 15:50 UTC (permalink / raw)
  To: Pekka Enberg; +Cc: Christoph Lameter, linux-kernel, linux-mm, Joonsoo Kim

We don't use the argument since commit 3b89d7d881a1dbb4da158f7eb5d6b3ceefc72810
('slub: move min_partial to struct kmem_cache'), so remove it

Signed-off-by: Joonsoo Kim <js1304@gmail.com>

diff --git a/mm/slub.c b/mm/slub.c
index 9c920a0..323778e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2766,7 +2766,7 @@ static unsigned long calculate_alignment(unsigned long flags,
 }
 
 static void
-init_kmem_cache_node(struct kmem_cache_node *n, struct kmem_cache *s)
+init_kmem_cache_node(struct kmem_cache_node *n)
 {
 	n->nr_partial = 0;
 	spin_lock_init(&n->list_lock);
@@ -2836,7 +2836,7 @@ static void early_kmem_cache_node_alloc(int node)
 	init_object(kmem_cache_node, n, SLUB_RED_ACTIVE);
 	init_tracking(kmem_cache_node, n);
 #endif
-	init_kmem_cache_node(n, kmem_cache_node);
+	init_kmem_cache_node(n);
 	inc_slabs_node(kmem_cache_node, node, page->objects);
 
 	add_partial(n, page, DEACTIVATE_TO_HEAD);
@@ -2876,7 +2876,7 @@ static int init_kmem_cache_nodes(struct kmem_cache *s)
 		}
 
 		s->node[node] = n;
-		init_kmem_cache_node(n, s);
+		init_kmem_cache_node(n);
 	}
 	return 1;
 }
@@ -3625,7 +3625,7 @@ static int slab_mem_going_online_callback(void *arg)
 			ret = -ENOMEM;
 			goto out;
 		}
-		init_kmem_cache_node(n, s);
+		init_kmem_cache_node(n);
 		s->node[nid] = n;
 	}
 out:
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] slub: remove unused argument of init_kmem_cache_node()
  2012-05-10 15:50 [PATCH] slub: remove unused argument of init_kmem_cache_node() Joonsoo Kim
@ 2012-05-10 15:56 ` Christoph Lameter
  2012-05-15  6:26 ` David Rientjes
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Lameter @ 2012-05-10 15:56 UTC (permalink / raw)
  To: Joonsoo Kim; +Cc: Pekka Enberg, linux-kernel, linux-mm

On Fri, 11 May 2012, Joonsoo Kim wrote:

> We don't use the argument since commit 3b89d7d881a1dbb4da158f7eb5d6b3ceefc72810
> ('slub: move min_partial to struct kmem_cache'), so remove it

Acked-by: Christoph Lameter <cl@linux.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] slub: remove unused argument of init_kmem_cache_node()
  2012-05-10 15:50 [PATCH] slub: remove unused argument of init_kmem_cache_node() Joonsoo Kim
  2012-05-10 15:56 ` Christoph Lameter
@ 2012-05-15  6:26 ` David Rientjes
  2012-05-16  6:46   ` Pekka Enberg
  1 sibling, 1 reply; 4+ messages in thread
From: David Rientjes @ 2012-05-15  6:26 UTC (permalink / raw)
  To: Joonsoo Kim; +Cc: Pekka Enberg, Christoph Lameter, linux-kernel, linux-mm

On Fri, 11 May 2012, Joonsoo Kim wrote:

> We don't use the argument since commit 3b89d7d881a1dbb4da158f7eb5d6b3ceefc72810
> ('slub: move min_partial to struct kmem_cache'), so remove it
> 
> Signed-off-by: Joonsoo Kim <js1304@gmail.com>

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] slub: remove unused argument of init_kmem_cache_node()
  2012-05-15  6:26 ` David Rientjes
@ 2012-05-16  6:46   ` Pekka Enberg
  0 siblings, 0 replies; 4+ messages in thread
From: Pekka Enberg @ 2012-05-16  6:46 UTC (permalink / raw)
  To: David Rientjes; +Cc: Joonsoo Kim, Christoph Lameter, linux-kernel, linux-mm

On Mon, 14 May 2012, David Rientjes wrote:
> On Fri, 11 May 2012, Joonsoo Kim wrote:
> 
> > We don't use the argument since commit 3b89d7d881a1dbb4da158f7eb5d6b3ceefc72810
> > ('slub: move min_partial to struct kmem_cache'), so remove it
> > 
> > Signed-off-by: Joonsoo Kim <js1304@gmail.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>

Applied, thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-05-16  6:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-10 15:50 [PATCH] slub: remove unused argument of init_kmem_cache_node() Joonsoo Kim
2012-05-10 15:56 ` Christoph Lameter
2012-05-15  6:26 ` David Rientjes
2012-05-16  6:46   ` Pekka Enberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox