From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Rafael Aquini <aquini@redhat.com>,
linux-mm@kvack.org, Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Josef Bacik <josef@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom: add sysctl to enable slab memory dump
Date: Fri, 24 Feb 2012 08:57:37 +0200 (EET) [thread overview]
Message-ID: <alpine.LFD.2.02.1202240856370.1917@tux.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1202231509510.26362@chino.kir.corp.google.com>
On Thu, 23 Feb 2012, David Rientjes wrote:
> > Great! So, why not letting the time tell us if this feature will be obsoleted
> > or not? I'd rather have this patch obsoleted by another one proven better, than
> > just stay still waiting for something that might, or might not, happen in the
> > future.
>
> Because (1) you're adding a sysctl that we don't want to obsolete and
> remove from the kernel that someone will come to depend on and then have
> to find an alternative solution like /dev/mem_notify, and (2) people parse
> messages like this that are emitted to the kernel log that we don't want
> to break in the future.
>
> So NACK on this approach.
Right. We should drop the sysctl and make it into a kernel command line
debugging option instead.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-24 6:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 11:53 Rafael Aquini
2012-02-22 13:17 ` Pekka Enberg
2012-02-22 16:04 ` Rafael Aquini
2012-02-22 13:55 ` Christoph Lameter
2012-02-22 16:14 ` Rafael Aquini
2012-02-22 16:29 ` Christoph Lameter
2012-02-23 0:44 ` David Rientjes
2012-02-23 15:02 ` Josef Bacik
2012-02-23 23:09 ` David Rientjes
2012-02-24 15:10 ` Josef Bacik
2012-02-24 21:45 ` David Rientjes
2012-02-24 21:52 ` Pekka Enberg
2012-02-24 23:51 ` David Rientjes
2012-02-23 15:22 ` Rafael Aquini
2012-02-23 16:03 ` Pekka Enberg
2012-02-23 23:17 ` David Rientjes
2012-02-24 6:57 ` Pekka Enberg [this message]
2012-02-24 10:03 ` David Rientjes
2012-02-24 10:05 ` Pekka Enberg
2012-02-24 10:38 ` Rafael Aquini
2012-02-29 3:39 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1202240856370.1917@tux.localdomain \
--to=penberg@kernel.org \
--cc=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox