From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id C64FD5F0001 for ; Sat, 30 May 2009 22:04:43 -0400 (EDT) Date: Sat, 30 May 2009 19:04:43 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH] Use kzfree in tty buffer management to enforce data sanitization In-Reply-To: <20090531015537.GA8941@oblivion.subreption.com> Message-ID: References: <20090531015537.GA8941@oblivion.subreption.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: "Larry H." Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Rik van Riel , Alan Cox List-ID: On Sat, 30 May 2009, Larry H. wrote: > > This patch doesn't affect fastpaths. This patch is ugly as hell. You already know the size of the data to clear. If we actually wanted this (and I am in _no_way_ saying we do), the only sane thing to do is to just do memset(buf->data, 0, N_TTY_BUF_SIZE); if (PAGE_SIZE != N_TTY_BUF_SIZE) kfree(...) else free_page(...) but quite frankly, I'm not convinced about these patches at all. I'm also not in the least convinced about how you just dismiss everybodys concerns. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org