From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Larry H." <research@subreption.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Use kzfree in tty buffer management to enforce data sanitization
Date: Sat, 30 May 2009 19:04:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0905301902530.3435@localhost.localdomain> (raw)
In-Reply-To: <20090531015537.GA8941@oblivion.subreption.com>
On Sat, 30 May 2009, Larry H. wrote:
>
> This patch doesn't affect fastpaths.
This patch is ugly as hell.
You already know the size of the data to clear.
If we actually wanted this (and I am in _no_way_ saying we do), the only
sane thing to do is to just do
memset(buf->data, 0, N_TTY_BUF_SIZE);
if (PAGE_SIZE != N_TTY_BUF_SIZE)
kfree(...)
else
free_page(...)
but quite frankly, I'm not convinced about these patches at all.
I'm also not in the least convinced about how you just dismiss everybodys
concerns.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-31 2:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 1:55 Larry H.
2009-05-31 2:04 ` Linus Torvalds [this message]
2009-05-31 2:35 ` Larry H.
2009-05-31 6:27 ` Pekka Enberg
2009-05-31 6:24 ` Pekka Enberg
2009-05-31 10:26 ` Alan Cox
2009-05-31 17:05 ` Linus Torvalds
2009-05-31 17:10 ` Alan Cox
2009-05-31 17:17 ` Pekka Enberg
2009-06-02 15:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0905301902530.3435@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=research@subreption.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox