From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
tytso@mit.edu, hughd@google.com, linux-mm@kvack.org
Subject: Re: [PATCH 01/15 v2] mm: add invalidatepage_range address space operation
Date: Fri, 14 Sep 2012 09:21:19 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1209140919580.2455@dhcp-196-88.bos.redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1209051234570.18459@new-host-2>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1959 bytes --]
On Wed, 5 Sep 2012, Luka? Czerner wrote:
> Date: Wed, 5 Sep 2012 12:42:54 -0400 (EDT)
> From: Luka? Czerner <lczerner@redhat.com>
> To: Christoph Hellwig <hch@infradead.org>
> Cc: Luk?? Czerner <lczerner@redhat.com>,
> Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org,
> linux-ext4@vger.kernel.org, tytso@mit.edu, hughd@google.com,
> linux-mm@kvack.org
> Subject: Re: [PATCH 01/15 v2] mm: add invalidatepage_range address space
> operation
>
> On Wed, 5 Sep 2012, Christoph Hellwig wrote:
>
> > Date: Wed, 5 Sep 2012 11:56:48 -0400
> > From: Christoph Hellwig <hch@infradead.org>
> > To: Luk?? Czerner <lczerner@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org,
> > linux-ext4@vger.kernel.org, tytso@mit.edu, hughd@google.com,
> > linux-mm@kvack.org
> > Subject: Re: [PATCH 01/15 v2] mm: add invalidatepage_range address space
> > operation
> >
> > On Wed, Sep 05, 2012 at 10:36:00AM -0400, Luk?? Czerner wrote:
> > > However if we would want to keep ->invalidatepage_range() and
> > > ->invalidatepage() completely separate then we would have to have
> > > separate truncate_inode_pages_range() and truncate_pagecache_range()
> > > as well for the separation to actually matter. And IMO this would be
> > > much worse...
> >
> > What's the problem with simply changing the ->invalidatepage prototype
> > to always pass the range and updating all instances for it?
> >
>
> The problem is that it would require me to implement this
> functionality for _all_ the file systems, because it is not just
> about changing the prototype, but also changing the implementation to
> be able to handle unaligned end of the range. This change would
> involve 20 file systems.
>
> It is not impossible though... so if people think that it's the
> right way to go, then I guess it can be done.
>
> -Lukas
Are there still any objections or comments about this ?
-Lukas
next prev parent reply other threads:[~2012-09-14 13:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 22:21 [PATCH 00/15 v2] Add " Lukas Czerner
2012-08-31 22:21 ` [PATCH 01/15 v2] mm: add " Lukas Czerner
2012-09-04 23:43 ` Andrew Morton
2012-09-05 14:36 ` Lukáš Czerner
2012-09-05 15:56 ` Christoph Hellwig
2012-09-05 16:42 ` Lukáš Czerner
2012-09-14 13:21 ` Lukáš Czerner [this message]
2012-08-31 22:21 ` [PATCH 02/15 v2] jbd2: implement jbd2_journal_invalidatepage_range Lukas Czerner
2012-09-04 14:52 ` J. Bruce Fields
2012-09-04 15:37 ` Lukáš Czerner
2012-09-04 17:44 ` J. Bruce Fields
2012-08-31 22:21 ` [PATCH 03/15 v2] ext4: implement invalidatepage_range aop Lukas Czerner
2012-08-31 22:21 ` [PATCH 04/15 v2] xfs: " Lukas Czerner
2012-08-31 22:21 ` [PATCH 05/15 v2] ocfs2: " Lukas Czerner
2012-08-31 22:21 ` [PATCH 06/15 v2] mm: teach truncate_inode_pages_range() to handle non page aligned ranges Lukas Czerner
2012-08-31 22:21 ` [PATCH 07/15 v2] ext4: Take i_mutex before punching hole Lukas Czerner
2012-09-10 12:00 ` Ashish Sangwan
2012-09-13 15:15 ` Lukáš Czerner
2012-08-31 22:21 ` [PATCH 08/15 v2] Revert "ext4: remove no longer used functions in inode.c" Lukas Czerner
2012-08-31 22:21 ` [PATCH 09/15 v2] Revert "ext4: fix fsx truncate failure" Lukas Czerner
2012-08-31 22:21 ` [PATCH 10/15 v2] ext4: use ext4_zero_partial_blocks in punch_hole Lukas Czerner
2012-08-31 22:21 ` [PATCH 11/15 v2] ext4: remove unused discard_partial_page_buffers Lukas Czerner
2012-08-31 22:21 ` [PATCH 12/15 v2] ext4: remove unused code from ext4_remove_blocks() Lukas Czerner
2012-08-31 22:21 ` [PATCH 13/15 v2] ext4: update ext4_ext_remove_space trace point Lukas Czerner
2012-08-31 22:21 ` [PATCH 14/15 v2] ext4: make punch hole code path work with bigalloc Lukas Czerner
2012-08-31 22:21 ` [PATCH 15/15 v2] ext4: Allow punch hole with bigalloc enabled Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1209140919580.2455@dhcp-196-88.bos.redhat.com \
--to=lczerner@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox