From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
npiggin@kernel.dk, rientjes@google.com,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Ville Tervo <ville.tervo@nokia.com>,
"Gustavo F. Padovan" <padovan@profusion.mobi>
Subject: Call Trace:Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1
Date: Thu, 24 Mar 2011 20:16:42 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1103242011230.31464@localhost6.localdomain6> (raw)
In-Reply-To: <20110324185258.GA28370@elte.hu>
After we made debugobjects working again, we got the following:
WARNING: at lib/debugobjects.c:262 debug_print_object+0x8e/0xb0()
Hardware name: System Product Name
ODEBUG: free active (active state 0) object type: timer_list hint: hci_cmd_timer+0x0/0x60
Pid: 2125, comm: dmsetup Tainted: G W 2.6.38-06707-gc62b389 #110375
Call Trace:
[<ffffffff8104700a>] warn_slowpath_common+0x7a/0xb0
[<ffffffff810470b6>] warn_slowpath_fmt+0x46/0x50
[<ffffffff812d3a5e>] debug_print_object+0x8e/0xb0
[<ffffffff81bd8810>] ? hci_cmd_timer+0x0/0x60
[<ffffffff812d4685>] debug_check_no_obj_freed+0x125/0x230
[<ffffffff810f1063>] ? check_object+0xb3/0x2b0
[<ffffffff810f3630>] kfree+0x150/0x190
[<ffffffff81be4d06>] ? bt_host_release+0x16/0x20
[<ffffffff81be4d06>] bt_host_release+0x16/0x20
[<ffffffff813a1907>] device_release+0x27/0xa0
[<ffffffff812c519c>] kobject_release+0x4c/0xa0
[<ffffffff812c5150>] ? kobject_release+0x0/0xa0
[<ffffffff812c61f6>] kref_put+0x36/0x70
[<ffffffff812c4d37>] kobject_put+0x27/0x60
[<ffffffff813a21f7>] put_device+0x17/0x20
[<ffffffff81bda4f9>] hci_free_dev+0x29/0x30
[<ffffffff81928be6>] vhci_release+0x36/0x70
[<ffffffff810fb366>] fput+0xd6/0x1f0
[<ffffffff810f8fe6>] filp_close+0x66/0x90
[<ffffffff810f90a9>] sys_close+0x99/0xf0
[<ffffffff81d4c96b>] system_call_fastpath+0x16/0x1b
That timer was introduced with commit 6bd32326cda(Bluetooth: Use
proper timer for hci command timout)
Timer seems to be running when the thing is closed. Removing the timer
unconditionally fixes the problem. And yes, it needs to be fixed
before the HCI_UP check.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
net/bluetooth/hci_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6/net/bluetooth/hci_core.c
===================================================================
--- linux-2.6.orig/net/bluetooth/hci_core.c
+++ linux-2.6/net/bluetooth/hci_core.c
@@ -584,6 +584,9 @@ static int hci_dev_do_close(struct hci_d
hci_req_cancel(hdev, ENODEV);
hci_req_lock(hdev);
+ /* Stop timer, it might be running */
+ del_timer_sync(&hdev->cmd_timer);
+
if (!test_and_clear_bit(HCI_UP, &hdev->flags)) {
hci_req_unlock(hdev);
return 0;
@@ -623,7 +626,6 @@ static int hci_dev_do_close(struct hci_d
/* Drop last sent command */
if (hdev->sent_cmd) {
- del_timer_sync(&hdev->cmd_timer);
kfree_skb(hdev->sent_cmd);
hdev->sent_cmd = NULL;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-24 19:16 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 14:40 Pekka Enberg
2011-03-24 14:21 ` Ingo Molnar
2011-03-24 14:41 ` Christoph Lameter
2011-03-24 16:50 ` Pekka Enberg
2011-03-24 17:26 ` Ingo Molnar
2011-03-24 17:43 ` Christoph Lameter
2011-03-24 17:56 ` Pekka Enberg
2011-03-24 18:01 ` Christoph Lameter
2011-03-24 18:06 ` Pekka Enberg
2011-03-24 18:15 ` Christoph Lameter
2011-03-24 18:20 ` Eric Dumazet
2011-03-24 18:47 ` Christoph Lameter
2011-03-24 18:51 ` Eric Dumazet
2011-03-24 19:02 ` Christoph Lameter
2011-03-24 19:04 ` Pekka Enberg
2011-03-24 18:55 ` Pekka Enberg
2011-03-24 18:59 ` Ingo Molnar
2011-03-24 19:03 ` Pekka Enberg
2011-03-24 19:05 ` Christoph Lameter
2011-03-24 19:14 ` Pekka Enberg
2011-03-24 19:36 ` Ingo Molnar
2011-03-24 19:41 ` Pekka Enberg
2011-03-24 19:51 ` Christoph Lameter
2011-03-24 20:01 ` Ingo Molnar
2011-03-24 20:08 ` Eric Dumazet
2011-03-24 20:43 ` Christoph Lameter
2011-03-25 15:13 ` Tejun Heo
2011-03-25 15:45 ` Christoph Lameter
2011-03-27 9:59 ` Avi Kivity
2011-03-24 19:02 ` Christoph Lameter
2011-03-27 9:57 ` Avi Kivity
2011-03-24 18:13 ` Pekka Enberg
2011-03-24 19:27 ` Ingo Molnar
2011-03-24 19:29 ` Pekka Enberg
2011-03-24 18:52 ` [boot crash #2] " Ingo Molnar
2011-03-24 19:10 ` Thomas Gleixner
2011-03-24 19:22 ` Ingo Molnar
2011-03-24 19:27 ` Pekka Enberg
2011-03-25 20:00 ` Ingo Molnar
2011-03-26 11:27 ` Ingo Molnar
2011-03-26 11:47 ` [PATCH] slub: Disable the lockless allocator Ingo Molnar
2011-03-26 17:45 ` Eric Dumazet
2011-03-26 19:18 ` Christoph Lameter
2011-03-26 19:30 ` Christoph Lameter
2011-03-26 19:49 ` Christoph Lameter
2011-03-26 19:57 ` Ingo Molnar
2011-03-26 21:36 ` Christoph Lameter
2011-03-26 20:00 ` Ingo Molnar
2011-03-26 22:18 ` Linus Torvalds
2011-03-27 1:29 ` Christoph Lameter
2011-03-27 1:57 ` Christoph Lameter
2011-03-27 7:52 ` Eric Dumazet
2011-03-28 10:32 ` [PATCH] percpu: avoid extra NOP in percpu_cmpxchg16b_double Eric Dumazet
2011-03-28 13:46 ` Christoph Lameter
2011-03-28 16:06 ` Tejun Heo
2011-03-28 6:12 ` [PATCH] slub: Disable the lockless allocator Pekka Enberg
2011-03-28 6:19 ` Ingo Molnar
2011-03-28 6:25 ` Pekka Enberg
2011-03-28 6:36 ` Ingo Molnar
2011-03-28 7:26 ` Eric Dumazet
2011-03-28 13:44 ` Christoph Lameter
2011-03-28 7:35 ` Tejun Heo
2011-03-26 19:30 ` Linus Torvalds
2011-03-26 17:58 ` [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 Linus Torvalds
2011-03-24 19:16 ` Thomas Gleixner [this message]
2011-03-24 19:23 ` Call Trace:Re: " Ingo Molnar
2011-03-24 20:04 ` Gustavo F. Padovan
2011-03-24 16:03 ` Ingo Molnar
2011-03-24 16:14 ` Ingo Molnar
2011-03-24 17:07 ` Pekka Enberg
2011-03-24 17:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1103242011230.31464@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@kernel.dk \
--cc=padovan@profusion.mobi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox