From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 70CFF6B0276 for ; Sun, 9 May 2010 21:35:32 -0400 (EDT) Date: Sun, 9 May 2010 18:32:32 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH 2/2] mm,migration: Fix race between shift_arg_pages and rmap_walk by guaranteeing rmap_walk finds PTEs created within the temporary stack In-Reply-To: Message-ID: References: <1273188053-26029-1-git-send-email-mel@csn.ul.ie> <1273188053-26029-3-git-send-email-mel@csn.ul.ie> <20100507105712.18fc90c4.kamezawa.hiroyu@jp.fujitsu.com> <20100509192145.GI4859@csn.ul.ie> <20100510094050.8cb79143.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , Minchan Kim , Christoph Lameter , Andrea Arcangeli , Rik van Riel , Peter Zijlstra List-ID: On Sun, 9 May 2010, Linus Torvalds wrote: > > So I never disliked that patch. I'm perfectly happy with a "don't migrate > these pages at all, because they are in a half-way state in the middle of > execve stack magic". Btw, I also think that Mel's patch could be made a lot _less_ magic by just marking that initial stack vma with a VM_STACK_INCOMPLETE_SETUP bit, instead of doing that "maybe_stack" thing. We could easily make that initial vma setup very explicit indeed, and then just clear that bit when we've moved the stack to its final position. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org