From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id D7C1F6B02B6 for ; Thu, 6 May 2010 22:15:22 -0400 (EDT) Date: Thu, 6 May 2010 19:12:59 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH 2/2] mm,migration: Fix race between shift_arg_pages and rmap_walk by guaranteeing rmap_walk finds PTEs created within the temporary stack In-Reply-To: <20100507105712.18fc90c4.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <1273188053-26029-1-git-send-email-mel@csn.ul.ie> <1273188053-26029-3-git-send-email-mel@csn.ul.ie> <20100507105712.18fc90c4.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , Minchan Kim , Christoph Lameter , Andrea Arcangeli , Rik van Riel , Peter Zijlstra List-ID: On Fri, 7 May 2010, KAMEZAWA Hiroyuki wrote: > > IIUC, move_page_tables() may call "page table allocation" and it cannot be > done under spinlock. Bah. It only does a "alloc_new_pmd()", and we could easily move that out of the loop and pre-allocate the pmd's. If that's the only reason, then it's a really weak one, methinks. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org