linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [patch][rfc] acpi: do not use kmem caches
Date: Mon, 01 Dec 2008 12:31:16 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0812011134410.3197@localhost.localdomain> (raw)
In-Reply-To: <20081201083128.GB2529@wotan.suse.de>



> What does everyone think about this patch?

Unexpected, Interesting.

We cut over to the native Linux allocator cache
from the ACPICA cache at a time when we had some
memory leaks, and it was important to be able
to walk up to a machine in the field that didn't
have any special build options and look in /proc
to find out what the different parts of our
sub-system were allocating.

I don't know the merits of SLAB vs. SLUB
or why Linux has two.  My local configs use SLAB
but I notice that recent Fedora kernels us SLUB.

>From an observability point of view, I guess I like SLAB
better because I can still see the 5 different ACPI caches
in /proc/slabinfo, while with SLUB I can see only one or two.

Note that these caches are used to interpret AML,
and how much AML you interpret depends a lot on the machine.
Some laptops will interpret AML all day long, while some
desktops and servers will run AML only at boot-time.

I guess my opinion is that I like the observatiblity we have now,
and that I'd need to see measurements showing that we're paying
too much for that observability.  I've also just now formed
an initial opinion on SLAB vs SLUB where I had none before.

thanks,
-Len

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2008-12-01 17:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01  8:31 Nick Piggin
2008-12-01 11:18 ` Pekka Enberg
2008-12-01 12:00   ` Nick Piggin
2008-12-01 13:12     ` Alexey Starikovskiy
2008-12-01 13:36       ` Nick Piggin
2008-12-01 14:14         ` Alexey Starikovskiy
2008-12-01 16:32           ` Nick Piggin
2008-12-01 17:18           ` Christoph Hellwig
2008-12-01 17:32             ` Alexey Starikovskiy
2008-12-01 13:37       ` Pekka Enberg
2008-12-01 14:02         ` Alexey Starikovskiy
2008-12-01 16:14           ` Nick Piggin
2008-12-01 16:45             ` Alexey Starikovskiy
2008-12-01 16:58               ` Nick Piggin
2008-12-01 17:20               ` Moore, Robert
2008-12-01 17:30                 ` Andi Kleen
2008-12-01 17:32                   ` Moore, Robert
2008-12-01 17:20               ` Christoph Hellwig
2008-12-01 17:49                 ` Alexey Starikovskiy
2008-12-01 17:53                 ` Len Brown
2008-12-01 18:10                   ` Nick Piggin
2008-12-31 22:04                     ` Len Brown
2009-01-05  4:14                       ` Nick Piggin
2009-01-05  5:43                         ` Skywing
2009-01-05  6:55                           ` Nick Piggin
2008-12-01 14:32         ` Christoph Lameter
2008-12-01 14:48           ` Alexey Starikovskiy
2008-12-01 16:20             ` Nick Piggin
2008-12-01 17:04               ` Alexey Starikovskiy
2008-12-01 17:12                 ` Nick Piggin
2008-12-01 17:25                   ` Pekka Enberg
2008-12-01 17:32                     ` Pekka Enberg
2008-12-01 17:36                       ` Alexey Starikovskiy
2008-12-01 17:48                         ` Pekka Enberg
2008-12-01 18:09                         ` Christoph Lameter
2008-12-01 17:43                   ` Alexey Starikovskiy
2008-12-01 17:31 ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0812011134410.3197@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox