From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 17 Nov 2008 09:35:25 -0800 (PST) From: Linus Torvalds Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment In-Reply-To: <4921A706.9030501@redhat.com> Message-ID: References: <20081115181748.3410.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20081115210039.537f59f5.akpm@linux-foundation.org> <49208E9A.5080801@redhat.com> <20081116204720.1b8cbe18.akpm@linux-foundation.org> <20081117153012.51ece88f.kamezawa.hiroyu@jp.fujitsu.com> <2f11576a0811162239w58555c6dq8a61ec184b22bd52@mail.gmail.com> <20081117155417.5cc63907.kamezawa.hiroyu@jp.fujitsu.com> <4921A1AF.1070909@redhat.com> <4921A706.9030501@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , LKML , linux-mm , Gene Heskett List-ID: Grr. Don't use attachments. Now I can't sanely reply and quote things with a sane default setting (yes, I could set "include attachements in reply", but that is _not_ a sane default setting, and anybody who claims it is is a moron). Why don't people learn? Anyway, without quoting, the thing is - your fix isn't any better. The more interesting part is how the fractions get combined, and that is indeed approximately "anon% = anon / (anon + file)". So you in many ways made the comment worse. It wasn't good before, but it's still not good, and now it comments on the part that isn't even interesting (ie it comments the _trivial_ fractional part) Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org