From: Linus Torvalds <torvalds@linux-foundation.org>
To: Rik van Riel <riel@redhat.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Gene Heskett <gene.heskett@gmail.com>
Subject: Re: [PATCH] vmscan: fix get_scan_ratio comment
Date: Mon, 17 Nov 2008 09:35:25 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0811170932390.3468@nehalem.linux-foundation.org> (raw)
In-Reply-To: <4921A706.9030501@redhat.com>
Grr. Don't use attachments. Now I can't sanely reply and quote things
with a sane default setting (yes, I could set "include attachements in
reply", but that is _not_ a sane default setting, and anybody who claims
it is is a moron).
Why don't people learn?
Anyway, without quoting, the thing is - your fix isn't any better. The
more interesting part is how the fractions get combined, and that is
indeed approximately "anon% = anon / (anon + file)".
So you in many ways made the comment worse. It wasn't good before, but
it's still not good, and now it comments on the part that isn't even
interesting (ie it comments the _trivial_ fractional part)
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-17 17:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 9:38 [PATCH] mm: evict streaming IO cache first KOSAKI Motohiro
2008-11-16 0:58 ` Rik van Riel
2008-11-16 5:00 ` Andrew Morton
2008-11-16 18:15 ` Linus Torvalds
2008-11-16 21:20 ` Rik van Riel
2008-11-16 21:28 ` Hugh Dickins
2008-11-17 4:47 ` Andrew Morton
2008-11-17 6:19 ` Nick Piggin
2008-11-17 6:30 ` KAMEZAWA Hiroyuki
2008-11-17 6:39 ` KOSAKI Motohiro
2008-11-17 6:54 ` KAMEZAWA Hiroyuki
2008-11-17 7:03 ` KOSAKI Motohiro
2008-11-17 8:22 ` KAMEZAWA Hiroyuki
2008-11-17 8:32 ` KOSAKI Motohiro
2008-11-17 16:22 ` Rik van Riel
2008-11-17 16:22 ` Linus Torvalds
2008-11-17 16:27 ` Rik van Riel
2008-11-17 16:37 ` Linus Torvalds
2008-11-17 16:54 ` Rik van Riel
2008-11-17 17:06 ` Linus Torvalds
2008-11-17 17:16 ` [PATCH] vmscan: fix get_scan_ratio comment Rik van Riel
2008-11-17 17:32 ` KOSAKI Motohiro
2008-11-17 17:35 ` Linus Torvalds [this message]
2008-11-17 18:53 ` Rik van Riel
2008-11-17 20:23 ` Rik van Riel
2008-11-18 0:06 ` [PATCH] vmscan: evict streaming IO first Rik van Riel
2008-12-01 20:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0811170932390.3468@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=gene.heskett@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox