From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: GIT head no longer boots on x86-64
Date: Wed, 15 Oct 2008 09:01:30 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810150859410.3288@nehalem.linux-foundation.org> (raw)
In-Reply-To: <48F60D56.6040209@gmail.com>
On Wed, 15 Oct 2008, Jiri Slaby wrote:
>
> Users usually do
> is_vmalloc_addr(a) ? vfree(a) : kfree(a);
> Even there it makes more sense to me.
Umm. No it doesn't.
That is exactly _wh7y_ "is_vmalloc_addr()" exists. But we sure as hell
don't ever want to trigger on modules for that.
If you think that "is_vmalloc_addr()" should trigger for any kernel
virtual address, why not just make it do so, then? And _name_ it so.
Names are important. In fact, naming is often _more_ important than the
implementation is. And that means that the implementation should follow
the naming, or the implementation is wrong.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-15 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0810130752020.3288@nehalem.linux-foundation.org>
2008-10-13 15:11 ` Jiri Slaby
2008-10-13 15:47 ` Alan Cox
2008-10-15 11:51 ` Ingo Molnar
2008-10-15 13:19 ` Jiri Slaby
2008-10-15 15:06 ` Linus Torvalds
2008-10-15 15:33 ` Jiri Slaby
2008-10-15 16:01 ` Linus Torvalds [this message]
2008-10-15 20:31 ` Arjan van de Ven
2008-10-15 15:35 ` Linus Torvalds
2008-10-16 10:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810150859410.3288@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox