From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Matt Mackall <mpm@selenic.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linuxfoundation.org>,
Pekka J Enberg <penberg@cs.helsinki.fi>
Subject: Re: [BUG] SLOB's krealloc() seems bust
Date: Tue, 7 Oct 2008 11:18:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0810071116050.3208@nehalem.linux-foundation.org> (raw)
In-Reply-To: <1223403082.26330.78.camel@lappy.programming.kicks-ass.net>
On Tue, 7 Oct 2008, Peter Zijlstra wrote:
> On Tue, 2008-10-07 at 10:57 -0700, Linus Torvalds wrote:
>
> > Peter - can you check with that
> >
> > > if (slob_page(sp))
> > > - return ((slob_t *)block - 1)->units + SLOB_UNIT;
> > > + return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT;
> >
> > thing using
> >
> > - return ((slob_t *)block - 1)->units + SLOB_UNIT;
> > + return ((slob_t *)block - 1)->units * SLOB_UNIT;
> >
> > instead?
>
> went splat on the second run...
Well, that makes it simple. I'll take Matt's patch as being "tested", and
somebody can hopefully explain where the extra unit comes from later.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-07 18:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 13:57 Peter Zijlstra
2008-10-07 14:07 ` Christoph Lameter
2008-10-07 14:13 ` Peter Zijlstra
2008-10-07 14:26 ` Christoph Lameter
2008-10-07 15:00 ` Matt Mackall
2008-10-07 15:20 ` Christoph Lameter
2008-10-07 15:58 ` Matt Mackall
2008-10-07 16:10 ` Peter Zijlstra
2008-10-07 16:37 ` Linus Torvalds
2008-10-07 16:37 ` Matt Mackall
2008-10-07 16:57 ` Pekka Enberg
2008-10-07 17:13 ` Matt Mackall
2008-10-07 17:31 ` Pekka Enberg
2008-10-07 23:08 ` Matt Mackall
2008-10-08 4:22 ` Nick Piggin
2008-10-08 4:46 ` Matt Mackall
2008-10-08 4:54 ` Nick Piggin
2008-10-08 5:11 ` Nick Piggin
2008-10-08 5:15 ` Matt Mackall
2008-10-08 6:43 ` Peter Zijlstra
2008-10-08 7:25 ` Pekka Enberg
2008-10-08 7:37 ` Peter Zijlstra
2008-10-08 7:39 ` Pekka Enberg
2008-10-07 17:57 ` Linus Torvalds
2008-10-07 18:11 ` Peter Zijlstra
2008-10-07 18:18 ` Linus Torvalds [this message]
2008-10-08 19:51 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0810071116050.3208@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linuxfoundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox