From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 30 Jul 2008 13:51:36 -0700 (PDT) From: Linus Torvalds Subject: Re: [patch v3] splice: fix race with page invalidation In-Reply-To: Message-ID: References: <20080730175406.GN20055@kernel.dk> <20080730194516.GO20055@kernel.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > It _is_ a bug fix. No it's not. It's still papering over a totally unrelated bug. It's not a "fix", it's a "paper-over". It doesn't matter if _behaviour_ changes. Can you really not see the difference? Afaik, everybody pretty much agreed what the real fix should be (don't mark the page not up-to-date, just remove it from the radix tree), I'm not seeing why you continue to push the patch that ALREADY GOT NAK'ed. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org