From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 24 Jun 2008 12:47:27 -0700 (PDT) From: Linus Torvalds Subject: Re: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations In-Reply-To: Message-ID: References: <20080621154607.154640724@szeredi.hu> <20080621154726.494538562@szeredi.hu> <20080624080440.GJ20851@kernel.dk> <20080624111913.GP20851@kernel.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 24 Jun 2008, Miklos Szeredi wrote: > > Or it can only happen if there was an I/O error on reading the page. Now, IO errors are something else. They should have the PG_error bit set, and we should just return EIO or something. That said, I'd not be surprised at all if error handling is broken. It's often been broken even in the _normal_ paths (ie totally normal "read()" etc). Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org