From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 24 Jun 2008 12:45:51 -0700 (PDT) From: Linus Torvalds Subject: Re: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations In-Reply-To: Message-ID: References: <20080621154607.154640724@szeredi.hu> <20080621154726.494538562@szeredi.hu> <20080624080440.GJ20851@kernel.dk> <20080624111913.GP20851@kernel.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 24 Jun 2008, Miklos Szeredi wrote: > > Right. But what if it's invalidated *before* becoming uptodate (if > you'd read my mail further, I discussed this). > > Why does invalidate_complete_page2() do ClearPageUptodate()? Dunno, > maybe it shoulnd't. But that would need a rather thorough audit of > all code checking PageUptodate()... Quite frankly, that shouldn't happen in the first place. Nothing should clear up-to-date on a page that is locked. Doesn't invalidate_complete_page() wait for the page to be unlocked already? That said, the VM people already discussed (I think for other reasons), removing the ClearPageUptodate(), because it has problems. There's talk about just unhashing the page or moving it to another radix tree or something. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org