From: Linus Torvalds <torvalds@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeff Chua <jeff.chua.linux@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Gabriel C <nix.or.die@googlemail.com>,
Hans Rosenfeld <hans.rosenfeld@amd.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Nishanth Aravamudan <nacc@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] x86: fix PAE pmd_bad bootup warning
Date: Tue, 6 May 2008 13:06:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805061302080.32269@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805062043580.11647@blonde.site>
On Tue, 6 May 2008, Hugh Dickins wrote:
>
> Fix Hans' good observation that follow_page() will never find pmd_huge()
> because that would have already failed the pmd_bad test: test pmd_huge in
> between the pmd_none and pmd_bad tests. Tighten x86's pmd_huge() check?
> No, once it's a hugepage entry, it can get quite far from a good pmd: for
> example, PROT_NONE leaves it with only ACCESSED of the KERN_PGTABLE bits.
I'd much rather have pdm_bad() etc fixed up instead, so that they do a
more proper test (not thinking that a PSE page is bad, since it clearly
isn't). And then, make them dependent on DEBUG_VM, because doing the
proper test will be more expensive.
Hmm?
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-05-06 20:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6a2187b0805051806v25fa1272xb08e0b70b9c3408@mail.gmail.com>
[not found] ` <20080506124946.GA2146@elte.hu>
[not found] ` <Pine.LNX.4.64.0805061435510.32567@blonde.site>
[not found] ` <alpine.LFD.1.10.0805061138580.32269@woody.linux-foundation.org>
2008-05-06 19:49 ` Hugh Dickins
2008-05-06 20:06 ` Linus Torvalds [this message]
2008-05-06 20:30 ` Hugh Dickins
2008-05-08 16:07 ` Nishanth Aravamudan
2008-05-06 20:22 ` Hans Rosenfeld
2008-05-06 20:36 ` Hugh Dickins
2008-05-07 23:39 ` Nishanth Aravamudan
2008-05-06 20:42 ` Dave Hansen
2008-05-08 14:34 ` Hans Rosenfeld
2008-05-08 14:39 ` Hans Rosenfeld
2008-05-08 14:52 ` Dave Hansen
2008-05-08 15:11 ` Hans Rosenfeld
2008-05-08 15:51 ` Dave Hansen
2008-05-08 16:19 ` Hans Rosenfeld
2008-05-08 16:33 ` Nishanth Aravamudan
2008-05-08 16:51 ` Hans Rosenfeld
2008-05-08 17:16 ` Nishanth Aravamudan
2008-05-08 18:42 ` Dave Hansen
2008-05-08 18:58 ` Hugh Dickins
2008-05-08 19:06 ` Dave Hansen
2008-05-08 18:48 ` Hugh Dickins
2008-05-08 19:49 ` Matt Mackall
2008-05-08 20:08 ` Dave Hansen
2008-05-08 20:02 ` Hans Rosenfeld
2008-05-08 20:16 ` Dave Hansen
2008-05-08 23:15 ` Dave Hansen
2008-05-14 19:01 ` Matt Mackall
2008-05-09 9:03 ` Paul Mundt
2008-05-08 16:42 ` Dave Hansen
2008-05-08 15:44 ` Nishanth Aravamudan
2008-05-07 4:40 ` Jeff Chua
2008-05-07 5:30 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805061302080.32269@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hans.rosenfeld@amd.com \
--cc=hpa@zytor.com \
--cc=hugh@veritas.com \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=nacc@us.ibm.com \
--cc=nix.or.die@googlemail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox