From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A4D1C388F7 for ; Tue, 10 Nov 2020 18:57:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1460208CA for ; Tue, 10 Nov 2020 18:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JqIkwI7m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1460208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 233E66B0036; Tue, 10 Nov 2020 13:57:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E4446B005C; Tue, 10 Nov 2020 13:57:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 120846B005D; Tue, 10 Nov 2020 13:57:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id D9DB36B0036 for ; Tue, 10 Nov 2020 13:57:27 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7F8198249980 for ; Tue, 10 Nov 2020 18:57:27 +0000 (UTC) X-FDA: 77469416934.26.suit71_3f11d28272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 59BA81804B647 for ; Tue, 10 Nov 2020 18:57:27 +0000 (UTC) X-HE-Tag: suit71_3f11d28272f7 X-Filterd-Recvd-Size: 4153 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 18:57:26 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id f21so6940370plr.5 for ; Tue, 10 Nov 2020 10:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/kb37eWBLDbjDnXmFWfjVVLRM7gSVNXEojlTedCdvIo=; b=JqIkwI7mdvEOLGgaIkz1ad0WiIuxYzgH0Yc+w9hHs29ATydarbNS09YbvxzgGRTA+P 4v2AYugE3z7Q2QIeD3OhEndw3WYxeW2qZ16+ck2tb5l8QvEnSQ3AF/yxD9OfnJXgSvfU 0kUI2sAyChygWhOdSkQLeY4rXbW4trVTu5JZ6TAtI7Nl4yewa5HMXRcieo9By2J0Sv/1 FZfrBAyhW2vT5RjBkJAMyeqeBzWN1CfhkwhjlYL1MDOnm0kZmD51aUsf2d8saiztrvEk sgMVef5QM8EDIEN1uklngMw5xuO1SAjFMC28c0Fo0sTiedCuw73rPx2KgT5Ctj3UEx+K 9MNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/kb37eWBLDbjDnXmFWfjVVLRM7gSVNXEojlTedCdvIo=; b=fLQa6ubp4CeLGcViRrsvbjiEkfyNnCNvJxtG+EvKPB0UOAnAfDRXQbljmM/WTfEF5z 9mKcX4CrHQFBb6qoOuKhfqig0MbTsyieMYVJq+ASQvk13AKlwKIb4PQ1tqjhnSlNnu2c TLDlM7MDPHxkoYrsYcmXzzRscFTMywqv1xrkxYvVsoeRk462bk88Dbbu9fTMDXNFSnGB 1GA7RgeVA2cbZwCN0S7lEeZxMGQ3RHqoOTP52ojtbrcg80fIB60EjPFtUxDvMU6ENCEe 6grDGEU6tSBe7gDzMpMApmfErNlYMqWJ8x6iryL+N5tX4KqwpimMZUTewEbcjaaVA1Ch /c9A== X-Gm-Message-State: AOAM532/S2+uh9vxi6QJhiiORQi0beKNVsuuRo3tB+mGBwpQdffckeJa 2uPUwYKeOI9kflBli5vWMzVMbA== X-Google-Smtp-Source: ABdhPJyLZxTXoySuldNuf+7kK21QLpddc/YRss2vggm6jrq66wCxAHCGe8DKoULcFL0dOTVlNbHSEQ== X-Received: by 2002:a17:902:e9c4:b029:d6:d5d6:c288 with SMTP id 4-20020a170902e9c4b02900d6d5d6c288mr18061556plk.22.1605034645751; Tue, 10 Nov 2020 10:57:25 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id s6sm13826565pgo.8.2020.11.10.10.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 10:57:24 -0800 (PST) Date: Tue, 10 Nov 2020 10:57:23 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Muchun Song cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, Andrew Morton , cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, shakeelb@google.com, guro@fb.com, Vlastimil Babka , laoar.shao@gmail.com, chris@chrisdown.name, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memcg/slab: Fix root memcg vmstats In-Reply-To: <20201110031015.15715-1-songmuchun@bytedance.com> Message-ID: References: <20201110031015.15715-1-songmuchun@bytedance.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.001271, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Nov 2020, Muchun Song wrote: > If we reparent the slab objects to the root memcg, when we free > the slab object, we need to update the per-memcg vmstats to keep > it correct for the root memcg. Now this at least affects the vmstat > of NR_KERNEL_STACK_KB for !CONFIG_VMAP_STACK when the thread stack > size is smaller than the PAGE_SIZE. > > Fixes: ec9f02384f60 ("mm: workingset: fix vmstat counters for shadow nodes") > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin Acked-by: David Rientjes I assume that without this fix that the root memcg's vmstat would always be inflated if we reparented? If that's accurate, perhaps this is deserving of a Cc: stable@vger.kernel.org # 5.3+