From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1491FC388F9 for ; Thu, 22 Oct 2020 18:00:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B85D2463B for ; Thu, 22 Oct 2020 18:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ked+h/0S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B85D2463B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E1756B0062; Thu, 22 Oct 2020 14:00:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66B686B0068; Thu, 22 Oct 2020 14:00:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 534AD6B006E; Thu, 22 Oct 2020 14:00:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22AE46B0062 for ; Thu, 22 Oct 2020 14:00:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0748181AEF07 for ; Thu, 22 Oct 2020 18:00:35 +0000 (UTC) X-FDA: 77400326430.30.shoe04_5410d1727252 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 7C13D180B3C8B for ; Thu, 22 Oct 2020 18:00:35 +0000 (UTC) X-HE-Tag: shoe04_5410d1727252 X-Filterd-Recvd-Size: 3771 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 18:00:34 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id h6so1385956pgk.4 for ; Thu, 22 Oct 2020 11:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+Jm50fe41wfDpU30qvqkj0sqMT/OM8dCaofZzxuvBXc=; b=Ked+h/0SpWqtiUKSQ+9P+ieLMEYOUTVO+Qm1xZegAoXCKTnpLFKnApIRgEQNuVl+xY 23Ki0jXwUy5jxqKjbS2p6j57kwY3nhDmCf37yAxUZIDdarrFWzYtYwszarW8AmN7W1tK QaLA/Ut1Q91UzjmR8M+CJmabUDT+4GAGKWWZS3k2oqfzBELUTGLx66J0bAP5qIk5i6tN Vs7wLG8jgWwCSeX8OCz+Zk0H6cEsdJR9buSyEVvsBbfH6HCvq04fuHMoF5qKL3KXNRtP LOqXn+Ehbt1GJq1WgSjRK/9M7jcRx4qYct5wkhxVGQiCFzuQpUmPwAr76h/VN6Cd6ywY QO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=+Jm50fe41wfDpU30qvqkj0sqMT/OM8dCaofZzxuvBXc=; b=ZHhTD31e+E6C42rhQPPE5SLYFt3UATLzbSD/Uz9wUCX8YKu+PM06rqZdOG+RKhgfXc n2xbGW7c3wuR8R/n9QQoI6PT+EdTAnjUjvywnIAK+gMwdneaRMm4aUwq884MEocjl1qW gmjp30fKuiJOQi4b67vbfsogqhMvVJgHBUrXQccB1M2bfaLJU0GKSpXKo7r4UWJIJXEA G9qngG4yBrZ40ixhnQBLPgiV0PtVNW4Nza4VcoHNdnH6N4NV2BHU1a1AwG4GJHOEgPw6 /gZXUB8QXTn3WxJKIRNJX/UBGbFewFk6WxaH0VxFO7TjSuUQJlvstNjWywqF8yQUQ6Jd qN8w== X-Gm-Message-State: AOAM533wUr5dqG6Yia1XArlsuOUc5rZ5KjjBnVUCKQ+3NiKUsKaNHgwA LuO3E63FtuMUl9FpiXv2NpyFRXK4fn/Dlg== X-Google-Smtp-Source: ABdhPJxn4taYlIWRahvkIvssJLMcCUQ84+ML8jbNY9JiGAhKblgzms/4vt1AYrhAFZgNDcVQ+MsviA== X-Received: by 2002:a65:5a0d:: with SMTP id y13mr3202032pgs.436.1603389633998; Thu, 22 Oct 2020 11:00:33 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id u12sm2512347pji.30.2020.10.22.11.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 11:00:32 -0700 (PDT) Date: Thu, 22 Oct 2020 11:00:32 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Johannes Weiner cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat In-Reply-To: <20201022151844.489337-1-hannes@cmpxchg.org> Message-ID: References: <20201022151844.489337-1-hannes@cmpxchg.org> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Oct 2020, Johannes Weiner wrote: > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We already track file > THP and shmem THP per node, so making them per-cgroup is only a matter > of switching from node to lruvec counters. All callsites are in places > where the pages are charged and locked, so page->memcg is stable. > > Signed-off-by: Johannes Weiner Acked-by: David Rientjes Nice!