From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8134EC433E0 for ; Tue, 11 Aug 2020 21:46:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32AA120771 for ; Tue, 11 Aug 2020 21:46:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="i5aLZDzI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32AA120771 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BB8D76B0002; Tue, 11 Aug 2020 17:46:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B68C36B0005; Tue, 11 Aug 2020 17:46:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A583F6B0006; Tue, 11 Aug 2020 17:46:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 918DA6B0002 for ; Tue, 11 Aug 2020 17:46:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B807181AEF09 for ; Tue, 11 Aug 2020 21:46:12 +0000 (UTC) X-FDA: 77139621384.07.stone46_201189026fe6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 0082D1803F9B2 for ; Tue, 11 Aug 2020 21:46:11 +0000 (UTC) X-HE-Tag: stone46_201189026fe6 X-Filterd-Recvd-Size: 3804 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Aug 2020 21:46:11 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id e4so107266pjd.0 for ; Tue, 11 Aug 2020 14:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ekEmY1/ax+L0gbL+grpGSGz9Q9IPbEokzoRjtsOxC1U=; b=i5aLZDzI1JL4lb6HPqx8WlSa8C3dyiMON9IxEKkfdzKyX6Os6yQyAUR23IJqWf4Vdb 4IcWkrGq99RdvEDChPbSJk+gs09bd8XXuG37lllChucpF03voHQJZRWrbNL8IMQpZsr9 Z7rWA8UDIjlKl6dvW7XvCzj865A6Ut2BeBHJWdOMemcfprHDi2bhgW85TY9qeD54/+xh AG4WqTPxUzZAe1txrRklwcZAEng16ZCQZAtWy73VSaXLUsZxbt1qih1cUVjp+QzkYl8Y fNVP1i1vug7EGn5lg7HZ3HNZP4CiQ+tnHxYrRY2jawn8bdASYGbfy6rEmDqt0i10Xn/K W/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ekEmY1/ax+L0gbL+grpGSGz9Q9IPbEokzoRjtsOxC1U=; b=THanyYV5UvJupBa6IfaKKgAm/GG9ioJouM7Jh6/qO6P2JuuN5EKWY7WbULy5JC/s2j q8pBLUFlvdGazuXHpsiqA9wQpgyUNgXqRi7B8FvTqhGcawJCagB/HOKKM/QXyeykR3Bs p03tCcwkBFljNVSStZtw+lZqN3gKEPsxF8xQEe3Q7pjYzVm9FwxGUIa31gNU73DySCQg U8RVwkqCJKNkzo9r2u/L2Q3Q+ioclvueQQ+smedJtD7wJSV6Dd4xY06FqSpg4zV5XiwA ZJBQ3RNHt+hMcdI+ReEtPp3jq0tRWaCsrNq5wuSM8iPhN25hdXrjA5fQ57pErDkbTGL7 biJw== X-Gm-Message-State: AOAM531BjyNrJ3gmFj4ZwxU0Acn50pEvwlQFSOyc7L4BAchfUA5gfBze rPxdMlOh8LNouDeRLP2vdzUpBA== X-Google-Smtp-Source: ABdhPJzOj+r0U6pHD/1nLCE5XH2G6juiTmwPB2fXh5kdWIxO6qV+5d6jN3/qvFyqNknLxLde9i7WAQ== X-Received: by 2002:a17:902:c40f:: with SMTP id k15mr2700290plk.330.1597182370358; Tue, 11 Aug 2020 14:46:10 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id q83sm51671pfc.31.2020.08.11.14.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 14:46:09 -0700 (PDT) Date: Tue, 11 Aug 2020 14:46:09 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Baoquan He cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, sonnyrao@chromium.org, yuzhao@google.com Subject: Re: [PATCH] Revert "mm/vmstat.c: do not show lowmem reserve protection information of empty zone" In-Reply-To: <20200811075412.12872-1-bhe@redhat.com> Message-ID: References: <20200811075412.12872-1-bhe@redhat.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0082D1803F9B2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Aug 2020, Baoquan He wrote: > This reverts commit 26e7deadaae1755faf1f6d1a68988c4b8348df59. > > Sonny reported that one of their tests started failing on the latest > kernel on their Chrome OS platform. The root cause is that the above > commit removed the protection line of empty zone, while the parser used > in the test relies on the protection line to mark the end of each zone. > > Let's revert it to avoid breaking userspace testing or applications. > Acked-by: David Rientjes No objection since I noted userspace parsing as a potential risk in https://marc.info/?l=linux-mm&m=158507790824995 but I didn't catch this earlier patch which could have led to the same thing.