From: David Rientjes <rientjes@google.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, sonnyrao@chromium.org,
yuzhao@google.com
Subject: Re: [PATCH] Revert "mm/vmstat.c: do not show lowmem reserve protection information of empty zone"
Date: Tue, 11 Aug 2020 14:46:09 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.23.453.2008111442301.3428139@chino.kir.corp.google.com> (raw)
In-Reply-To: <20200811075412.12872-1-bhe@redhat.com>
On Tue, 11 Aug 2020, Baoquan He wrote:
> This reverts commit 26e7deadaae1755faf1f6d1a68988c4b8348df59.
>
> Sonny reported that one of their tests started failing on the latest
> kernel on their Chrome OS platform. The root cause is that the above
> commit removed the protection line of empty zone, while the parser used
> in the test relies on the protection line to mark the end of each zone.
>
> Let's revert it to avoid breaking userspace testing or applications.
>
Acked-by: David Rientjes <rientjes@google.com>
No objection since I noted userspace parsing as a potential risk in
https://marc.info/?l=linux-mm&m=158507790824995 but I didn't catch this
earlier patch which could have led to the same thing.
prev parent reply other threads:[~2020-08-11 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 7:54 Baoquan He
2020-08-11 8:34 ` David Hildenbrand
2020-08-11 21:46 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.23.453.2008111442301.3428139@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sonnyrao@chromium.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox