From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F057C433E1 for ; Tue, 11 Aug 2020 21:40:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 36F5120756 for ; Tue, 11 Aug 2020 21:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NF9nDofa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36F5120756 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D8CB6B0002; Tue, 11 Aug 2020 17:40:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A036B0005; Tue, 11 Aug 2020 17:40:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5784E6B0006; Tue, 11 Aug 2020 17:40:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 41A8A6B0002 for ; Tue, 11 Aug 2020 17:40:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DF0DD45AB for ; Tue, 11 Aug 2020 21:40:17 +0000 (UTC) X-FDA: 77139606474.08.loaf91_381373d26fe6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id B345E1819E773 for ; Tue, 11 Aug 2020 21:40:17 +0000 (UTC) X-HE-Tag: loaf91_381373d26fe6 X-Filterd-Recvd-Size: 4361 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Aug 2020 21:40:17 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id d19so7321698pgl.10 for ; Tue, 11 Aug 2020 14:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=xh1nFmiFsyPig921Fwk7pCd225ZkH0tJsK6GH0jcq9Q=; b=NF9nDofa//83sJtBUpVI2eC0Kf/qGVDT+X35ri144puGnCvGTfZJ6RgZxtEcRnp4eY Pbq/3SQIFzN0UySOyqMQfvQn8Ao2+zgiUuCSiV9Lo87/6Bqh8P6CfIHVx3NArVEGCk30 SlG3Ra8q9tR0JsITHSC2K4bdr/IVIuDPD544ywmn4iZq8ns1zfx9Qjf6e+8VfrR3b5kS K0fej6N70MA7/2OK2TIG4OFhogiydqY3JuSewDBDGCMMnlSb1CQZqXG47EPmKxTtjU3O BwQyJQY5A0HJGHk8zaTMuWkqCRFu6nAOQuYlmUbfhCbK/83tTNkcbJODqq3N8etyGNFI SflA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=xh1nFmiFsyPig921Fwk7pCd225ZkH0tJsK6GH0jcq9Q=; b=hvR93BujY/9b1Zoa3s4rbJyR5PuMcp4XmDUsM6DpBoFcbdsAmKQRM2TIa7t603IU62 uFV65dMCl1YU+K4LjWB5V1MtwIsrIVK3ojBGhG2mAZ1RQKC+KTIrI0dX53Qd9fDd9/30 DtbHy7ELqICiuV9HSX59cMQom2OmhStCz5Zzx+ylcFXM57zka5kjkEP62wWb+8U5kEzx xszOVm7uFkSS/7B1p0KLzZ2r+QSu5pLEuZg0DYwu/5YkIlrcJ1ys+CkRnILjKacxcUKt 9IgeLBdxiwyFbwdNtk/UmiQlNjucEhEdDrsHijUhMrAhmun3m8bo7f++6L/SlfXwY2Vx GySQ== X-Gm-Message-State: AOAM5314eYvBAhr5WnBjQo2Hco0CaO/tOCp2v9jRLNre/z36lqZfgnV6 ccv0fiTriv6wddMyIKuiP+wY4A== X-Google-Smtp-Source: ABdhPJyEA7lC5GKVFyT2NcG/5JHdpnv77bPF4IxLESV+U/UJuN955B9GPwSnjylIiwsvAopuI9cxeQ== X-Received: by 2002:aa7:96c5:: with SMTP id h5mr8025042pfq.195.1597182016109; Tue, 11 Aug 2020 14:40:16 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id w6sm96744pgr.82.2020.08.11.14.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 14:40:15 -0700 (PDT) Date: Tue, 11 Aug 2020 14:40:14 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Abel Wu cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , hewenliang4@huawei.com, hushiyuan@huawei.com, "open list:SLAB ALLOCATOR" , open list Subject: Re: [PATCH] mm/slub: fix missing ALLOC_SLOWPATH stat when bulk alloc In-Reply-To: <20200811022427.1363-1-wuyun.wu@huawei.com> Message-ID: References: <20200811022427.1363-1-wuyun.wu@huawei.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B345E1819E773 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Aug 2020, wuyun.wu@huawei.com wrote: > From: Abel Wu > > The ALLOC_SLOWPATH statistics is missing in bulk allocation now. > Fix it by doing statistics in alloc slow path. > > Signed-off-by: Abel Wu > --- > mm/slub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index df93a5a0e9a4..5d89e4064f83 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2600,6 +2600,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, > void *freelist; > struct page *page; > > + stat(s, ALLOC_SLOWPATH); > + > page = c->page; > if (!page) { > /* > @@ -2788,7 +2790,6 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s, > page = c->page; > if (unlikely(!object || !node_match(page, node))) { > object = __slab_alloc(s, gfpflags, node, addr, c); > - stat(s, ALLOC_SLOWPATH); > } else { > void *next_object = get_freepointer_safe(s, object); > Acked-by: David Rientjes > -- > 2.28.0.windows.1 Lol :)