From: David Rientjes <rientjes@google.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Roman Gushchin <guro@fb.com>, Greg Thelen <gthelen@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Re: [patch] mm, memcg: provide a stat to describe reclaimable memory
Date: Wed, 15 Jul 2020 10:33:52 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.23.453.2007151031020.2788464@chino.kir.corp.google.com> (raw)
In-Reply-To: <20200715071522.19663-1-sjpark@amazon.com>
On Wed, 15 Jul 2020, SeongJae Park wrote:
> > An alternative to this would also be to change from an "available" metric
> > to an "anon_reclaimable" metric since both the deferred split queues and
> > lazy freeable memory would pertain to anon. This would no longer attempt
> > to mimic MemAvailable and leave any such calculation to userspace
> > (anon_reclaimable + (file + slab_reclaimable) / 2).
> >
> > With this route, care would need to be taken to clearly indicate that
> > anon_reclaimable is not necessarily a subset of the "anon" metric since
> > reclaimable memory from compound pages on deferred split queues is not
> > mapped, so it doesn't show up in NR_ANON_MAPPED.
> >
> > I'm indifferent to either approach and would be happy to switch to
> > anon_reclaimable if others agree and doesn't foresee any extensibility
> > issues.
>
> Agreed, I was also once confused about the 'MemAvailable'. The 'reclaimable'
> might be better to understand.
>
Hi SeongJae,
I'm leaning in that direction now too, actually, because I reasoned that
determining the precise amount of anon that can be reclaimed would require
subtracting (file + slab_reclaimable) / 2, which is awkward :)
So I'll send a follow-up patch to add only an anon_reclaimable field which
is good enough for our purposes unless others would like to have more
discussion.
Thanks!
next prev parent reply other threads:[~2020-07-15 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 3:18 David Rientjes
2020-07-15 7:00 ` David Rientjes
2020-07-15 7:15 ` SeongJae Park
2020-07-15 17:33 ` David Rientjes [this message]
2020-07-16 20:58 ` [patch] mm, memcg: provide an anon_reclaimable stat David Rientjes
2020-07-16 21:07 ` Shakeel Butt
2020-07-16 21:28 ` David Rientjes
2020-07-17 1:37 ` Shakeel Butt
2020-07-17 8:34 ` Michal Hocko
2020-07-17 14:39 ` Johannes Weiner
2020-07-15 13:10 ` [patch] mm, memcg: provide a stat to describe reclaimable memory Chris Down
[not found] ` <alpine.DEB.2.23.453.2007151046320.2788464@chino.kir.corp.google.com>
2020-07-17 12:17 ` Chris Down
2020-07-17 19:37 ` David Rientjes
2020-07-20 7:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.23.453.2007151031020.2788464@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=sjpark@amazon.com \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox