From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FD4C433E0 for ; Sun, 5 Jul 2020 23:09:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF6B120672 for ; Sun, 5 Jul 2020 23:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p2sFZDFD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF6B120672 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E45996B0003; Sun, 5 Jul 2020 19:09:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF6926B0005; Sun, 5 Jul 2020 19:09:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0CBB6B0006; Sun, 5 Jul 2020 19:09:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id BC5356B0003 for ; Sun, 5 Jul 2020 19:09:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3BB1F180AD801 for ; Sun, 5 Jul 2020 23:09:17 +0000 (UTC) X-FDA: 77005565154.17.mist85_2a0d92826ea7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 0A1F1180D0181 for ; Sun, 5 Jul 2020 23:09:17 +0000 (UTC) X-HE-Tag: mist85_2a0d92826ea7 X-Filterd-Recvd-Size: 3873 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sun, 5 Jul 2020 23:09:16 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id t6so17552053pgq.1 for ; Sun, 05 Jul 2020 16:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2l4COFb6V1KRR/RNdKpKtkxL5GRiMz2GZZhgHCHSIpc=; b=p2sFZDFD6/EKlNmmfh8lG1HneAHTpaijszRUz//4dCKLqcXo7g9+97tnjnbhsVsrad J29p4bQtHR0LHvEr+iNBZL7oImtJSlys5LA2K2asDvIR6w0qYsY/Fc461k+NJCKzZvR1 JljH/KQ0v4z+Sd94PetOl8j93vXznn5Qwy79frjDWYQ6JziktDTWzBsVcIRqaSqozbgk UAQVpiAXHBQLEhsIWCXjxP7t4DkTGabgFjEzIs9VwQylIrkbk0l6ifrQJDQfgYKZzy8n OaCofdYkfJNyNrcvv7sYPyBG3YS2E3cUwl0Iy42/PaGEOPT0AQvmCMJ2IuyleqW48jFK daxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2l4COFb6V1KRR/RNdKpKtkxL5GRiMz2GZZhgHCHSIpc=; b=pF+SSHOZh+i4uDVMoFOoaXTzJjbmao4I/hmwF5s6EvjGgkxMqJuUHr2omPmCvBCjDM M75cCjG8YllYbRwvGRwd/h2ixf1Xr14pFQaskUeQ85mUnTZj8o67TQ/V7Two2DvxCLDV CK41B1gz7YvY30WxouunHK1uNz9X3Ygfi+rxWbuxbWriPv1/p/siXx9WvDU3KvHJClXl SpBPaW29wvu6zONktrLJ/kXuUwWEM0RkdtroGPtvfpydZtToiEo757Uwa2DVhsnN8Iqn t8NjMoS0GOc6UUImb3BAXRME++hp1g56FY7lk0+Fou2mG136FGjMFc1shRhrOcRotJ8J 45BQ== X-Gm-Message-State: AOAM532RrrNTZLr4tPLzYq6l1hj7YcIqFnzWQEU+LKWpIcdbs8U6iFiJ Nz6LJEkvO+F/Xhey/kWAkF4tUg== X-Google-Smtp-Source: ABdhPJzUdH8nyKlluBVsZ/nK1eYWu/VSg772VPkaTD2ANB0r7hRiD6QJawxAdiFSXeDAD/pFluT7vg== X-Received: by 2002:a62:8fc6:: with SMTP id n189mr14579579pfd.10.1593990555428; Sun, 05 Jul 2020 16:09:15 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id f3sm16413404pju.54.2020.07.05.16.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2020 16:09:14 -0700 (PDT) Date: Sun, 5 Jul 2020 16:09:13 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Long Li cc: willy@infradead.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v6] mm, slab: Check GFP_SLAB_BUG_MASK before alloc_pages in kmalloc_order In-Reply-To: <20200704035027.GA62481@lilong> Message-ID: References: <20200704035027.GA62481@lilong> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0A1F1180D0181 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Jul 2020, Long Li wrote: > kmalloc cannot allocate memory from HIGHMEM. Allocating large amounts > of memory currently bypasses the check and will simply leak the memory > when page_address() returns NULL. To fix this, factor the > GFP_SLAB_BUG_MASK check out of slab & slub, and call it from > kmalloc_order() as well. In order to make the code clear, the warning > message is put in one place. > > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Pekka Enberg > Cc: Christoph Lameter > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Signed-off-by: Long Li Acked-by: David Rientjes Thanks!