From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72159E77184 for ; Tue, 17 Dec 2024 17:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05CDE6B008C; Tue, 17 Dec 2024 12:33:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00D4E6B0092; Tue, 17 Dec 2024 12:33:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF006B0093; Tue, 17 Dec 2024 12:33:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE9436B008C for ; Tue, 17 Dec 2024 12:33:27 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 33D851C7384 for ; Tue, 17 Dec 2024 17:33:27 +0000 (UTC) X-FDA: 82905146772.12.6B2DDFD Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf10.hostedemail.com (Postfix) with ESMTP id 89ECBC001D for ; Tue, 17 Dec 2024 17:33:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=EaNS0yuh; spf=pass (imf10.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734456791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=04pTIo5ApWySSg1irLecWsNtdqZYhiDphbsaLsL2++E=; b=j6JcWy5QLXH7YMtkmnFsB40OEffX7lVAXkqGJ7SqU9cXRthWIAWDDfc5mnHQUumx1cLNcZ Kv9hCkvhvp4g+dUtkeLuQvC5SXoGH2HzEo0VWz03+DM6cLk0F9wrHhAmkMS5AA7NmJoTh3 actVHSNyPtMLqC5cBhM2KNS4x+2HnwA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=EaNS0yuh; spf=pass (imf10.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734456791; a=rsa-sha256; cv=none; b=2k4Z6+VcZ2sEUSdRiIF8YsfOTtwMgki9+w5vymXyMI/1oKMU/TyDtbX8rsZ+rcuTKKUTb/ HAbKq+PrlO0VIgnFc9pZVo9/pEddGLWpnlKLnwQZDUNm3ANKSReQ5J4utuh07cgH6GyeXJ Y6o7s+p68nYOyBPaxyhsgTfuV43/Stc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=04pTIo5ApWySSg1irLecWsNtdqZYhiDphbsaLsL2++E=; b=EaNS0yuhC4s6iN6WnIrnfVVUKM6YqvVWkIbgcSrxq8z6qdZxbvXYN/B4 9evJrozXCky5ezt+egWk2fvFzCjCGhd/6dlOUNDuVRw1L3nJUFrUuyJTW ezsZJHG7RK8qkYyuGARiZzCMp891lCLljEEn1C5atxdbFGiHm+3aLIRi2 4=; X-IronPort-AV: E=Sophos;i="6.12,242,1728943200"; d="scan'208";a="104581457" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 18:33:20 +0100 Date: Tue, 17 Dec 2024 18:33:18 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Alexander Gordeev cc: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?ISO-8859-15?Q?Thomas_Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?ISO-8859-15?Q?Roger_Pau_Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v3 02/19] coccinelle: misc: Add secs_to_jiffies script In-Reply-To: Message-ID: References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-2-ddfefd7e9f2a@linux.microsoft.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 89ECBC001D X-Stat-Signature: dnjt8jj7xaj7an5o3scxb3kc5hpfnohm X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734456791-536101 X-HE-Meta: U2FsdGVkX1/RhmfSyTByF62oZnepf5rUbHm/tsX8FIvif+XkToJ+s0h8S5LLohM1I1R9nQ9B6I6xSooxrvQBggR6vWtScpXJwMwMpqFY0mqvrhcXAjZ0gBilY19HQxOD6RhUGq8aKzs0Pb/qP4oLCtPtY3IWWCu7RMXsYrQ8IBknmQXJcDAY1OBIRa7yxA9TWq7m3vldTkRJv/uUTKSGVseAl1BOVxi17U/KH6upA8IBVLR/clCeWo0FSGugbRsvojcsCv2U8x7AapJO2uOiuEyXHw/ETpYTnZEcazzassZ1vmr8ulTSIQ5jgN6BtSygesAU/VOzuMCHsebBXaSqKiSW4AqLn8WBd/18kvPmJ6Y7nOJNaSOSdJNpnAMBU7Z7nNRCWrazuT3pSTVfA0MKUARm/uDHJ5xvO2ESidUI5GLV5/6QfYhEddMQKGnkWK5gA19izyoBnBZdgkWosh8C4HJ+f1ZJXomL9FWTQFFUtRV33TWcLziy/ZdNwmnmrQnO7YoPkcyfqLamnWuCPT/jhPBov25bFL/ZWGP7s+I8nCNzXH29PpI2C5eCB7TVsldED7K1x2O82cwx8nSE6at1zIqwRBVUYM0w2Z/GQ8yi6dQpCPkTPhzT0q952kCxRidyGtXx3XVaAZpnynB8F/NYJ/0lm3drjm3+KCIlZnT3+21a85EV2rTQ7oKMMLYpTIEVINtOyepKxZOTFQCrWj3ixWtbhIzAEycc6RYlNccaxEH9MBGSdKUNy29PLUVo0cDM6qgnW/q5l86M3qQCd32hm3dqWh9tOXNoHQCCsliNxAFWt1MTrax/R59qtfv158ODeO5H6HEYcYkE5/XnC/k4luub8di+W4AqrMU3Qz8zyPaXsv6V4F7RSSbHN67Bp4DeJ+/UT9WpPpUIrsX7kjauXk7QdFzK+sRg8aE9A4gTcTUgZaialMXrcaWVCGUeYNjTesO7ouc8bsvX//S87EF Bk1HvQjI G09G5iNXOlccjtk4DE9SjKFEtQLqlMFA3d7B6pPQu+lFjUHZb0LJBy1Laz9lSI8z8gCr+oSVQNWQUC0mmtd803oF2xDlynokL6pWwfIpyjUpT/Q7q1iKUg6vZ2dm5V2BF3PuG/B7tWrMslEvqID7PgJHHy9oj3z3iSmL/CLYXy1Zz9+KQdm6OeF4T6Yaaq1/wqfiMoC2c/aHXHNEtU+FVDwZ5sLQwXCKSb6sT9xAI4lrWoHxcGz6tXAM++C8RrjkaJwJFqoXuTx4jdjMLcgHIRCy257JpuBIJwiHL4ogkqmlynFuM80gMOIdHIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 17 Dec 2024, Alexander Gordeev wrote: > On Tue, Dec 10, 2024 at 10:02:33PM +0000, Easwar Hariharan wrote: > > Hi Easwar, > > > This script finds and suggests conversions of timeout patterns that > > result in seconds-denominated timeouts to use the new secs_to_jiffies() > > API in include/linux/jiffies.h for better readability. > > > > Suggested-by: Anna-Maria Behnsen > > Signed-off-by: Easwar Hariharan > > --- > > scripts/coccinelle/misc/secs_to_jiffies.cocci | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > > new file mode 100644 > > index 0000000000000000000000000000000000000000..8bbb2884ea5db939c63fd4513cf5ca8c977aa8cb > > --- /dev/null > > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > > @@ -0,0 +1,22 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/// > > +/// Find usages of: > > +/// - msecs_to_jiffies(value*1000) > > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) > > +/// > > +// Confidence: High > > +// Copyright: (C) 2024 Easwar Hariharan, Microsoft > > +// Keywords: secs, seconds, jiffies > > +// > > + > > +virtual patch > > + > > +@depends on patch@ constant C; @@ > > + > > +- msecs_to_jiffies(C * 1000) > > ++ secs_to_jiffies(C) > > + > > +@depends on patch@ constant C; @@ > > + > > +- msecs_to_jiffies(C * MSEC_PER_SEC) > > ++ secs_to_jiffies(C) > > If you used this script only, then it did not seem to recognize line arch/s390/mm/cmm.c:207 > > mod_timer(&cmm_timer, jiffies + msecs_to_jiffies(cmm_timeout_seconds * MSEC_PER_SEC)); There is the requirement that C is a constant, and cmm_timeout_seconds is not considered to be a constant, ie it is not all capital letters. Indeed, it doesn't seem to be a constant at all. I don't know if the requirement of being a comstant is really necessary. julia > > Thanks! >