From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E653C25B74 for ; Mon, 27 May 2024 19:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 044F26B0088; Mon, 27 May 2024 15:51:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F36636B008A; Mon, 27 May 2024 15:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFFF56B008C; Mon, 27 May 2024 15:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C3BAE6B0088 for ; Mon, 27 May 2024 15:51:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7A2051C1E20 for ; Mon, 27 May 2024 19:51:40 +0000 (UTC) X-FDA: 82165220760.13.676E5C0 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by imf05.hostedemail.com (Postfix) with ESMTP id 54D65100006 for ; Mon, 27 May 2024 19:51:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=XxfKlNff; spf=pass (imf05.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.83 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716839498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q3snwzwmWuoJD/WMzTv7X0Z3Dos/RKpUUf3kUzMbFkI=; b=Ks0LT8z4zDj7VuSXS1IWqyWav1iS5m/AdB7fpzAvc17STCJpGtNU3EtvwZ7bvyr3fbiYfa e/FRSMzsiUOCXh98qSygupUIPCTzTW8k1Gp3Ztey9Aj05lWdDXHIx6EsdJTi46iZvDZru7 UFUfGufrM8baQf3lT8AeaCsSpfF1oL0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=XxfKlNff; spf=pass (imf05.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.83 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716839498; a=rsa-sha256; cv=none; b=0DjNl4AUzusKmlwEQxseqb0kyugWdcAq66tb5HgN00eY+sUn9Xd+Lzk66INYHHyBrS3518 aINMRedE0y/sd+nph7VYtJAQ0KMP2un1vGydFoRUj/7w1QZgpRQInG4V0Z5zMsfJBaikVV wndkgcRbmp+8wLK4f7d122DCoHkLqSI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=Q3snwzwmWuoJD/WMzTv7X0Z3Dos/RKpUUf3kUzMbFkI=; b=XxfKlNffEX4U+45+4yhIKbR9JyMVXsFlPoR+7xU84Mj1JrMmRZj055D5 zqjEDdW4i+yof9sfgJ5nMRHJto0/m2G/ywePMze2HuJpScribZXF9Sdf1 d8DnTauqHqzF4AzZElh1EueqjVdJ9i1VArmaI9h11aC/bPieICIG5ncgf k=; X-IronPort-AV: E=Sophos;i="6.08,193,1712613600"; d="scan'208";a="167684911" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2024 21:51:35 +0200 Date: Mon, 27 May 2024 21:51:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Uladzislau Rezki cc: "Paul E. McKenney" , Vlastimil Babka , "linux-mm@kvack.org" , RCU , cocci@inria.fr Subject: Re: [cocci] patch idea: convert trivial call_rcu users to kfree_rcu In-Reply-To: Message-ID: References: <68b85796-c674-4691-936a-2051849f4692@suse.cz> <6b7e3ed9-d974-cb3b-6839-a6b7cf5f5a36@inria.fr> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 54D65100006 X-Stat-Signature: 811mmu4ngyoyb3pnceqcfgh447nyp93w X-Rspam-User: X-HE-Tag: 1716839497-757864 X-HE-Meta: U2FsdGVkX1/iJrFdhkHBmNgg6XWyR7GhQAIDFpaPHIQZJ5R8Kf4SILubtDrWepGdJXyQb9NUY9FIwjUNNK+fyaxnEhiHbp1LDjBMlITITJT162+7kmv6MSw/D57YqKFp393qxaBicj26Wo3MjEzhTaV9ezHGh/TfDveIU+tLdeLD/A9JgMJnOrp6O+Ns6OKMyPwzA8mLsaKHyfoISfSe2mtV93SnJEZxAhl5htTfkmjCXutiC/7yykUvkuRuIvi36l91HE7EyRkkwZj5EAtYjLXNbL6C0bPOAiEV8LvJon1j4drhAS307sEgLOmcbBcc+ke4lrJ+xobuWFQLlxa/5LiVa56Sgk8c0gEcHASCskHoaTzwqrhmcEKPgLwbsxLPTcvT4lXcA4aBYFgi93VEoE8DDtO2OLEV9co9Rv0dXiMPfOvXsZ5wnbyoZb4TKisnSSYtXw3x991UIGIsKGzGqnA2ZnvAuRZJuN5vALmFiWeFG2QtYhGi4Zqm8SWzMAtaiCNeFeMbgt+PSzFGYJexCBu7MZatpRFZza0WFmGY5XG7FJavyVLzRyBZAq+a0RUaogCsWfQhBkyOm+UF4SlmvSeEQa/qOgsOUu2nnxMzXoY2jTy7FkASzUWRiTTyLKA/CyYq/LEp3STF4SOi1E3cN0sPbrwfpsnnP9GH4a49a5DlU+x395beup3Rjbx/7r9hvrPPMOpVpPmEcjd1ccvjgP+kDxH8BrzSDt4CtptEmktC0A6b76OZ2OXLeyitx35zXDcV+qsARwTiHsZrdMduRvsN3bQfgOu8Mr0ie9TKJZ3v6MEMcZtyCYcY3Lm3Q4r9kr9gKZ25oZ0pfBz4y9GSSOhxy2/dfs9F5s1x4gKVrzqwLQZ8HuPrhuv6SbB/Ou7OWGrOda6Dmb7qKuOK1Q5tQn3F3zTk48DD9lG8UiZG81go+C/BzwbNLvIEJqsM/r76sIY634i+5+uduKfRYW7 SihqPnOS mU35JQNzED1rWpI38vJFHlNNDHML7I1K2RbBtGUKHZBa5GaTfy7txnm+iu9qFy35QU1tH4jiUSJezXv7XVUEWlSGsltn5yoLCJW/sc8C58vIsYrCRcVfp6FauaBTJwOMcA6XRrVj9yOYXH58R7ytHmzlhZpvPBsH96E/qYy6MXJuZ1iOM0QbZj7/PToT2J2LwEMGYqTfBi16LMyy0iRcuze3yAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 27 May 2024, Uladzislau Rezki wrote: > On Mon, May 27, 2024 at 12:27:14PM -0700, Paul E. McKenney wrote: > > On Mon, May 27, 2024 at 10:13:40AM +0200, Julia Lawall wrote: > > > > > > > > > On Mon, 27 May 2024, Vlastimil Babka wrote: > > > > > > > Hi, > > > > > > > > one bit from LSF/MM discussions is that there might be call_rcu users with a > > > > callback that only does a kmem_cache_free() to a specific cache. Since SLOB > > > > was removed, it's always ok to use kfree() and thus also kfree_rcu() on > > > > allocations from kmem_cache_alloc() in addition to kmalloc(). Thus, such > > > > call_rcu() users might be simplified to kfree_rcu(). I found some cases > > > > semi-manually, but I'd expect coccinelle could help here so if anyone wants > > > > to take this task, feel free to. > > > > > > Thanks for the suggestion! I will try to look into it. > > > > Thank you both! > > > I wanted to take an action on it but Julia was first. So, please go ahead :) If you want to try, please go ahead. We can compare results. julia