From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92FDFE71D3F for ; Fri, 29 Sep 2023 14:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5C448D0078; Fri, 29 Sep 2023 10:33:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0BB98D0023; Fri, 29 Sep 2023 10:33:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FB7D8D0078; Fri, 29 Sep 2023 10:33:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D9508D0023 for ; Fri, 29 Sep 2023 10:33:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F8AC1CA91D for ; Fri, 29 Sep 2023 14:33:26 +0000 (UTC) X-FDA: 81289878012.02.E96EB16 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf11.hostedemail.com (Postfix) with ESMTP id 3D25840017 for ; Fri, 29 Sep 2023 14:33:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=oQbVR4tg; spf=pass (imf11.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695998003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=mutlpFKb3gjRQb6viCRSAcgYwnxE9/jgT8FxPe/+DBo=; b=F0o6xTZlIGGvr1iDhqpd0VhNX47b+dCYIB+FJKMASi6clOnYRzKL5bya+8Mdt/Sj7V3IkX aspTVPj+JqK/Eckq+E5B571lqZg0UEP5z1ExrvwiYLvC0vG+0CkbnNFk7HQZgZbY603Awk iFgB3EXsJHZ9UPvkBPYJ1U9EIW2LTEQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695998003; a=rsa-sha256; cv=none; b=kQwU50+3MYpQ8hdp61o1PjiiZGy3bJCdOcDDEbopLw+qv6pxbdHlyFppX+qHrFRFH0XklO 3syMo+wwBjDIF1W3Drgw02EEw+LCT9pEd9VLHT1RBItu9F+90gZyqqnNFC3Z2wOQxDCAou Kin1TGG0eZv6D2d9o3id76mvblMgfKM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=oQbVR4tg; spf=pass (imf11.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=mutlpFKb3gjRQb6viCRSAcgYwnxE9/jgT8FxPe/+DBo=; b=oQbVR4tgRhvhR8LntVWA0lEVpuPe0HGTz6l4WgGoOCW4CgOQtc8AUp3j u3eezdFGC0xMhjZU8WHkrfko1VfsDpyJdN7p3mceRDUFiiyqD6f4f9bH+ E9PbWeFFBLZxHSAvRWtZ1Y6cx8xG+VkyN68wYjAstA+sZK6A6mc803O+T M=; X-IronPort-AV: E=Sophos;i="6.03,187,1694728800"; d="scan'208";a="67354079" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 16:33:20 +0200 Date: Fri, 29 Sep 2023 16:33:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Qi Zheng cc: Andrew Morton , Linux Memory Management List , Muchun Song , oe-kbuild-all@lists.linux.dev Subject: [linux-next:master 8008/8345] mm/shrinker.c:100:1-7: preceding lock on line 83 (fwd) Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 3D25840017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xiwohbej4q9kpptht3gtsp7cfwpz7aem X-HE-Tag: 1695998002-437503 X-HE-Meta: U2FsdGVkX19rH1NOTgHnjwUoF71XG/iAG9quArVE+H1Pmk2vzZBo8o22ttgG9Jw8tRZbL1HFLRLA3WyJxicO6hTE5FoJ9L+bCeK6HnDtdBAJAEm+wj6ToUe0Vpxme9M+sV/OmuhrxNyqlJw9ZWd4uMLUIxTVt/nDlHW32qz5jl6SiVMsQcLQg44ArMhixMMe1ocmP4vhj4R4t4KcjXE5gCNiZrCqxXGQAIt5Yc+QEW7IH4xGVJU/nVVtyqs8q4ue1IH2RuHeIQrfqnyo7/2zPJDqfMtuxC2rv8SkiLGlprUxT4mw0dp7UvC/f1/Wi7h75xr7grD2U452QOaITQAfInVkWCupkab67Ax4N5/NIwJaeQ4Z0XY2IH95a/sffcdAix9Kj+yLVKO7E9u89DL7NT6rOXD7JDLpvGuHN1t12u2BUiLnYhvQcDA9waF8o4GwdYfrrfb3nYxo5mAeqDOzAt4fdRfODi+SPHkZf5RXaRf7mPD5KvPczz3zivXDJ8WNfJqxpooeEFYqFp1R70J8WYGRVFoD5PtrU0kTpZY12fD0b/H11jGZDtH17ICBzs7GvqYLK0l2cLoGWK+ALY+VJVSL8VClU+B+igdc0oONZj97/yIt1VhLTm/WWwhbPVrAohYrZBVc4RFGfdsTS/RJBFEMzzal8IuqcdSFmrHQe5C3zfsSXa91DIjDgl2pYVttMCHgdidgR+FZI3Im013SGYD7L/QHxgTl0/mmvEDAzfXHsMndwqqe9DMyXocwaka8dqK9cEr5qIHcQohqI++fPFtJsQ1ttv3u238X6aa6TCkvbg+TQxE8jEw6aNdrMt9EGt2iFPXecNq49011WjwtlauaooM9aDO8C3Oy95HUv/Kg+gAKCiAjzZrbN2ebtLbTek+p9S2ZYnmV4eybLGmsbBqd3W7dr+CVmoN+raraitqatYJjtAA1hTcuHYWycc/py4DdEVhS3Rs63F2kufb Akaz2lO5 Jf00W1SrS9PbM6fBqmABdqvb5AGlZ1IE7ArOSjt4ztrk9j33+ycT8Z8cDtonwI0bk6BovX1hMRkJZ3etyowZ5SnesegpAxTddyGl76c4bYAnMwm29X1ajYZuqPP1qD14lmD32NUyQvTOgLMwe7MIau4m/4K9TS2lGhRfeKUvXklryXA7REZ+PiPdXA0xlSiwWHT4PHrk8+7gAjUoeaduKVSUu3DUbBlasgYBvivtmsvhnIQR/EwXh+MT6ZykJGzH+xn47EoA5bkbVUWJ1hu+5g9zE5QxNmyYjeFFwR2NQnwuXhkbBGPK7E4cJAR2bMZeP8/7Y9qWUiiLbuD1X/H1XEgek4sTkzmxgzMbm3yxhBRKYu3N+DZ7qvqwHZPMATFx3sdQmEy4+1OdrrVLGzELXCp4KinX0r0K0YYUE6SedDVjGM9ehyfFMg9qZYzi/VISaq5Bond5+FU5rf0WlFWEpFfSF5CkPZK5PhM0x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Should shrinker_mutex be released on the error path? julia ---------- Forwarded message ---------- Date: Fri, 29 Sep 2023 21:31:25 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 8008/8345] mm/shrinker.c:100:1-7: preceding lock on line 83 BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: Qi Zheng CC: Andrew Morton CC: Linux Memory Management List CC: Muchun Song Hi Qi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: df964ce9ef9fea10cf131bf6bad8658fde7956f6 commit: 3b0ec351e30dfbe71675deb22da8a9fe1894c87f [8008/8345] mm: shrinker: convert shrinker_rwsem to mutex :::::: branch date: 9 hours ago :::::: commit date: 3 days ago config: x86_64-randconfig-103-20230927 (https://download.01.org/0day-ci/archive/20230929/202309292114.VMjkyBBq-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230929/202309292114.VMjkyBBq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202309292114.VMjkyBBq-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> mm/shrinker.c:100:1-7: preceding lock on line 83 vim +100 mm/shrinker.c 2babd0d6e9cfca Qi Zheng 2023-09-11 76 2babd0d6e9cfca Qi Zheng 2023-09-11 77 int alloc_shrinker_info(struct mem_cgroup *memcg) 2babd0d6e9cfca Qi Zheng 2023-09-11 78 { 2babd0d6e9cfca Qi Zheng 2023-09-11 79 struct shrinker_info *info; b6884b5f15cf5a Qi Zheng 2023-09-11 80 int nid, ret = 0; b6884b5f15cf5a Qi Zheng 2023-09-11 81 int array_size = 0; 2babd0d6e9cfca Qi Zheng 2023-09-11 82 3b0ec351e30dfb Qi Zheng 2023-09-11 @83 mutex_lock(&shrinker_mutex); b6884b5f15cf5a Qi Zheng 2023-09-11 84 array_size = shrinker_unit_size(shrinker_nr_max); 2babd0d6e9cfca Qi Zheng 2023-09-11 85 for_each_node(nid) { b6884b5f15cf5a Qi Zheng 2023-09-11 86 info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); b6884b5f15cf5a Qi Zheng 2023-09-11 87 if (!info) b6884b5f15cf5a Qi Zheng 2023-09-11 88 goto err; 2babd0d6e9cfca Qi Zheng 2023-09-11 89 info->map_nr_max = shrinker_nr_max; b6884b5f15cf5a Qi Zheng 2023-09-11 90 if (shrinker_unit_alloc(info, NULL, nid)) b6884b5f15cf5a Qi Zheng 2023-09-11 91 goto err; 2babd0d6e9cfca Qi Zheng 2023-09-11 92 rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); 2babd0d6e9cfca Qi Zheng 2023-09-11 93 } 3b0ec351e30dfb Qi Zheng 2023-09-11 94 mutex_unlock(&shrinker_mutex); 2babd0d6e9cfca Qi Zheng 2023-09-11 95 2babd0d6e9cfca Qi Zheng 2023-09-11 96 return ret; b6884b5f15cf5a Qi Zheng 2023-09-11 97 b6884b5f15cf5a Qi Zheng 2023-09-11 98 err: b6884b5f15cf5a Qi Zheng 2023-09-11 99 free_shrinker_info(memcg); b6884b5f15cf5a Qi Zheng 2023-09-11 @100 return -ENOMEM; 2babd0d6e9cfca Qi Zheng 2023-09-11 101 } 2babd0d6e9cfca Qi Zheng 2023-09-11 102 :::::: The code at line 100 was first introduced by commit :::::: b6884b5f15cf5acf6886ec0704d799035477ad7e mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} :::::: TO: Qi Zheng :::::: CC: Andrew Morton -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki