From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F21BC001B0 for ; Sun, 25 Jun 2023 15:40:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46E96B0074; Sun, 25 Jun 2023 11:40:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F6896B0075; Sun, 25 Jun 2023 11:40:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E5B46B0078; Sun, 25 Jun 2023 11:40:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 816E76B0074 for ; Sun, 25 Jun 2023 11:40:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5AE3C1A013B for ; Sun, 25 Jun 2023 15:40:40 +0000 (UTC) X-FDA: 80941682640.16.410A3FC Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf27.hostedemail.com (Postfix) with ESMTP id 64E3840005 for ; Sun, 25 Jun 2023 15:40:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b="UhRzhEV/"; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf27.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687707638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=CnvPqkEF1ZvSVZjF3J3bBF7ccQ4Zr/q4D30SasyGiyY=; b=fKdmh/RqPOU1Sir/q3rwDHVknhwUhzkC6f9y2Hbbdq1CMuc+ZHrTHx2FqRWsdrfSmYWqtB vA9bDSKklphld+jKUwoSLWJUy5xk+k6CjG1lZ0bZK5fH7AgJzZL9nzKfOe683scWjYS2rO Pc8FjXZYIYVng4BBx7qd/eayl+nIWI0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b="UhRzhEV/"; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf27.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687707638; a=rsa-sha256; cv=none; b=FbZ7RwDo+1ohfnkfrO5Etbp+4EuRhjn8skGm9jD8czMGdMRRK283oFheN8V+XSHBbE1qcZ ZgztJHV8YQwKM7l0Os6nR6mjxptrHcGgAZ66LN4iZG/ZzEWxYzSGxeuZMon/bfeLuvt3lG W09knQFY1MRZqeKLWevrE3lzYY3f2oo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=CnvPqkEF1ZvSVZjF3J3bBF7ccQ4Zr/q4D30SasyGiyY=; b=UhRzhEV/gmytq6wuwa8I0+sle5IrZootZAaQCwTN95k3j5VjTbKTaFLv 9yCCrwmfkDk7BLiv22+R9u3pBmQVA1iWOdRJrL43PDWuPs02u9AAJN/VS HmZkTwkW4v1Ys/KmfYWo3wJha6Qjb/wtc3wwhaejMI8EpUpVStn+wjsRc M=; X-IronPort-AV: E=Sophos;i="6.01,157,1684792800"; d="scan'208";a="59750718" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 17:40:35 +0200 Date: Sun, 25 Jun 2023 17:40:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Andreas Gruenbacher cc: Linux Memory Management List , oe-kbuild-all@lists.linux.dev Subject: [linux-next:master 9366/12162] fs/gfs2/super.c:762:0-1: preceding lock on line 738 (fwd) Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 64E3840005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: j6fz5hnr5m569p4yy85goecyks51sn5p X-HE-Tag: 1687707637-44432 X-HE-Meta: U2FsdGVkX1/ELmS1BCE8H7xWnbosar265wTXKwCLbhEFOyeoxuXTInRLt/T+XSRMpqI9jYsFMAZyEij8nb+lsah+2rEap5um+GPIXm98nQzxsNTVB/DT8IqT0Us6Vz/1P0iy3tTVsRwC3QNNOfyztXauBaiZZPFAMVfOzrBGHgmRCNPn76pvWTQsZYKguY5oV2IJmLyoUCI29RlUiZAkeF23pMF16vaHuALmJt4FTik3N+KNuz2clSMG57wFaZMuWFvKg7s/zoI6o3zn7855bM/cuqNaaNntWFwpy+rgGr836ea30Qfxmswtn6J/UnVDbAQ6wL8ftsomMJn0/Wzj7HJOXaqauDGju2nk7mSdthzHV7jEj7RHbrVgYs3ifezYNwZTklvitFKT0Fl95Gn4a9P8Al6YY/NmHoBBRu5u0/IhqJHDKf9R+U185pQsujPtkMVHu6lPUz/1cYwgmaBhZMpHbuax/1pmcEEGXpdelBbnimJpmXLg/oOcr5asEZ3FLDLaS9sQI1fJZU6xrSnueqhfVodLB5Hwo/bcJEwR+iPlv2UI3Mwjkxzr2tRDz1AYitkQAg7gXA4DaoEGCyHrgqQDNW+aGi5prRHr7POxklWPIP6Ov4ES/94ImeZRBFgLAS103avb+e/Pj8xawZPOD68bJgASpw/Rd+QpU/kLFAPQrKLsh7/ZRbShijB2MrGDQH3PeqEeodbQGv3X4xEdzR6adGyuBhABHuV7hnDgvYGoH4UlQ2NEZNYU/QR3P+Kuu+SfDU1hAQk9Euh1HFzLuwW816Q5sg388VorckexE2OaY1fOo+IXzqe7F89KysOBuBfxEEi//QUh4IJHbTPZ/N703IEOaH8cTJeM7gkFl/PwpV8ZVxHS528Lczk5jzlNbVusqbDYDoU/xIH7CR6/BVNxauTBp2yVJQcnasL6y7SZw1UvCVpE3gTEhohgLo0OTB61QFRS2NfATx6UthL rSDlnBLS PdS6ZqJ/8mQkbeCWo45bavpXBaoP8pdYMajOn14pew/fZvbF4kX23P+fkkY5TZgkSnFhqDcA/ZAS22Z8Onj7iDOzkwsJL+j6Kc4c3DmC4UvLrRW6EHY++EqQqR03KGxZkBiLMuu9tsNGfMnx3n99n0Eh0x+xzYK/PxKRemqjWkIr9LcSNpwRy9ExKJENZyIVovyE7YXA5XmHtjfb62Lh3pV+1DuN21ffp86tdBmeF30bD0QOzMYIK0j7hR0KTzE72R0S3V5U0zrz7QtJOlwWjBQC95w9DcXN4du2uBU4Zw+nviJByhTcziu73M359b82oAR3aEEcdoXxRzo2cQX3aE/NxZHGNhDLkJr4VkKeCX39Q4obNllvJKdgB/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Please check whether an unlock is needed in the goto out case. julia ---------- Forwarded message ---------- Date: Sun, 25 Jun 2023 23:06:48 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 9366/12162] fs/gfs2/super.c:762:0-1: preceding lock on line 738 BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: Andreas Gruenbacher tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8d2be868b42c08290509c60515865f4de24ea704 commit: 4ad135d5be933a17cd07d09a77470ca169baf869 [9366/12162] gfs2: Rework freeze / thaw logic :::::: branch date: 2 days ago :::::: commit date: 10 days ago config: s390-randconfig-r054-20230625 (https://download.01.org/0day-ci/archive/20230625/202306252241.Lahe2YsR-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230625/202306252241.Lahe2YsR-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202306252241.Lahe2YsR-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> fs/gfs2/super.c:762:0-1: preceding lock on line 738 vim +762 fs/gfs2/super.c 4ad135d5be933a Andreas Gruenbacher 2022-11-14 731 4ad135d5be933a Andreas Gruenbacher 2022-11-14 732 void gfs2_freeze_func(struct work_struct *work) 4ad135d5be933a Andreas Gruenbacher 2022-11-14 733 { 4ad135d5be933a Andreas Gruenbacher 2022-11-14 734 struct gfs2_sbd *sdp = container_of(work, struct gfs2_sbd, sd_freeze_work); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 735 struct super_block *sb = sdp->sd_vfs; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 736 int error; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 737 4ad135d5be933a Andreas Gruenbacher 2022-11-14 @738 mutex_lock(&sdp->sd_freeze_mutex); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 739 error = -EBUSY; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 740 if (atomic_read(&sdp->sd_freeze_state) != SFS_UNFROZEN) 4ad135d5be933a Andreas Gruenbacher 2022-11-14 741 goto out_unlock; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 742 4ad135d5be933a Andreas Gruenbacher 2022-11-14 743 error = gfs2_freeze_locally(sdp); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 744 if (error) 4ad135d5be933a Andreas Gruenbacher 2022-11-14 745 goto out_unlock; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 746 4ad135d5be933a Andreas Gruenbacher 2022-11-14 747 gfs2_freeze_unlock(&sdp->sd_freeze_gh); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 748 atomic_set(&sdp->sd_freeze_state, SFS_FROZEN); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 749 4ad135d5be933a Andreas Gruenbacher 2022-11-14 750 error = gfs2_do_thaw(sdp); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 751 if (error) 4ad135d5be933a Andreas Gruenbacher 2022-11-14 752 goto out; 4ad135d5be933a Andreas Gruenbacher 2022-11-14 753 4ad135d5be933a Andreas Gruenbacher 2022-11-14 754 atomic_set(&sdp->sd_freeze_state, SFS_UNFROZEN); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 755 4ad135d5be933a Andreas Gruenbacher 2022-11-14 756 out_unlock: 4ad135d5be933a Andreas Gruenbacher 2022-11-14 757 mutex_unlock(&sdp->sd_freeze_mutex); 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 758 deactivate_super(sb); 4ad135d5be933a Andreas Gruenbacher 2022-11-14 759 out: 4ad135d5be933a Andreas Gruenbacher 2022-11-14 760 if (error) 4ad135d5be933a Andreas Gruenbacher 2022-11-14 761 fs_info(sdp, "GFS2: couldn't freeze filesystem: %d\n", error); 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 @762 } 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 763 :::::: The code at line 762 was first introduced by commit :::::: 2e60d7683c8d2ea21317f6d9f4cd3bf5428ce162 GFS2: update freeze code to use freeze/thaw_super on all nodes :::::: TO: Benjamin Marzinski :::::: CC: Steven Whitehouse -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki