Please check lines 373 and 374. julia ---------- Forwarded message ---------- Date: Sat, 19 Nov 2022 01:11:33 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 4420/8929] drivers/iio/adc/max11410.c:373:5-32: duplicated argument to & or | BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: Ibrahim Tilki CC: Jonathan Cameron tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67 commit: 15b258dc79f8cc891c255505361b3226b10d6663 [4420/8929] iio: adc: add max11410 adc driver :::::: branch date: 10 hours ago :::::: commit date: 2 weeks ago config: parisc-randconfig-c004-20221118 compiler: hppa-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Julia Lawall cocci warnings: (new ones prefixed by >>) >> drivers/iio/adc/max11410.c:373:5-32: duplicated argument to & or | vim +373 drivers/iio/adc/max11410.c 15b258dc79f8cc Ibrahim Tilki 2022-10-03 350 15b258dc79f8cc Ibrahim Tilki 2022-10-03 351 static int max11410_configure_channel(struct max11410_state *st, 15b258dc79f8cc Ibrahim Tilki 2022-10-03 352 struct iio_chan_spec const *chan) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 353 { 15b258dc79f8cc Ibrahim Tilki 2022-10-03 354 struct max11410_channel_config cfg = st->channels[chan->address]; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 355 unsigned int regval; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 356 int ret; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 357 15b258dc79f8cc Ibrahim Tilki 2022-10-03 358 if (chan->differential) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 359 ret = max11410_set_input_mux(st, chan->channel, chan->channel2); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 360 else 15b258dc79f8cc Ibrahim Tilki 2022-10-03 361 ret = max11410_set_input_mux(st, chan->channel, 15b258dc79f8cc Ibrahim Tilki 2022-10-03 362 MAX11410_AINN_GND); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 363 15b258dc79f8cc Ibrahim Tilki 2022-10-03 364 if (ret) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 365 return ret; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 366 15b258dc79f8cc Ibrahim Tilki 2022-10-03 367 regval = FIELD_PREP(MAX11410_CTRL_VREFP_BUF_BIT, cfg.buffered_vrefp) | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 368 FIELD_PREP(MAX11410_CTRL_VREFN_BUF_BIT, cfg.buffered_vrefn) | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 369 FIELD_PREP(MAX11410_CTRL_REFSEL_MASK, cfg.refsel) | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 370 FIELD_PREP(MAX11410_CTRL_UNIPOLAR_BIT, cfg.bipolar ? 0 : 1); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 371 ret = regmap_update_bits(st->regmap, MAX11410_REG_CTRL, 15b258dc79f8cc Ibrahim Tilki 2022-10-03 372 MAX11410_CTRL_REFSEL_MASK | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 @373 MAX11410_CTRL_VREFN_BUF_BIT | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 374 MAX11410_CTRL_VREFN_BUF_BIT | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 375 MAX11410_CTRL_UNIPOLAR_BIT, regval); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 376 if (ret) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 377 return ret; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 378 15b258dc79f8cc Ibrahim Tilki 2022-10-03 379 regval = FIELD_PREP(MAX11410_PGA_SIG_PATH_MASK, cfg.sig_path) | 15b258dc79f8cc Ibrahim Tilki 2022-10-03 380 FIELD_PREP(MAX11410_PGA_GAIN_MASK, cfg.gain); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 381 ret = regmap_write(st->regmap, MAX11410_REG_PGA, regval); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 382 if (ret) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 383 return ret; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 384 15b258dc79f8cc Ibrahim Tilki 2022-10-03 385 if (cfg.settling_time_us) 15b258dc79f8cc Ibrahim Tilki 2022-10-03 386 fsleep(cfg.settling_time_us); 15b258dc79f8cc Ibrahim Tilki 2022-10-03 387 15b258dc79f8cc Ibrahim Tilki 2022-10-03 388 return 0; 15b258dc79f8cc Ibrahim Tilki 2022-10-03 389 } 15b258dc79f8cc Ibrahim Tilki 2022-10-03 390 -- 0-DAY CI Kernel Test Service https://01.org/lkp