From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13167C433F5 for ; Tue, 11 Oct 2022 12:16:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EE676B0072; Tue, 11 Oct 2022 08:16:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2774A6B0073; Tue, 11 Oct 2022 08:16:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F08B6B0074; Tue, 11 Oct 2022 08:16:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EA7756B0072 for ; Tue, 11 Oct 2022 08:16:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F9A98030D for ; Tue, 11 Oct 2022 12:16:06 +0000 (UTC) X-FDA: 80008565532.19.28573D9 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [195.130.132.51]) by imf29.hostedemail.com (Postfix) with ESMTP id 7F5A7120031 for ; Tue, 11 Oct 2022 12:16:05 +0000 (UTC) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:3da6:62e6:8ab0:ff90]) by baptiste.telenet-ops.be with bizsmtp id WcG32800732x5mf01cG38w; Tue, 11 Oct 2022 14:16:03 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.93) (envelope-from ) id 1oiEB0-001GtL-Oy; Tue, 11 Oct 2022 14:16:02 +0200 Date: Tue, 11 Oct 2022 14:16:02 +0200 (CEST) From: Geert Uytterhoeven X-X-Sender: geert@ramsan.of.borg To: Liam Howlett cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v14 07/70] lib/test_maple_tree: add testing for maple tree In-Reply-To: <20220906194824.2110408-8-Liam.Howlett@oracle.com> Message-ID: References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220906194824.2110408-8-Liam.Howlett@oracle.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665490566; a=rsa-sha256; cv=none; b=x2Z/d7NElGx+07AoR4RNFWU0UNUvygJNllbAgDGIPgONlvNk7+aQYJg2RAnQehDQqNCM4a qj9jHhLSQKAI9dQtgr0X6QF/X5Rw9FiHBJDGea+TRLeF0cQj3MLZqBGAmCctLsnNQQGHlG 7RvOORHCkVOB4xEJyrl5RSGmocrFIUc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of geert@linux-m68k.org has no SPF policy when checking 195.130.132.51) smtp.mailfrom=geert@linux-m68k.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665490566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfp14dSf5997dap+ljwxw/B788k82rPJQiOezGmY5Yg=; b=LsfUGtLBDqstKHXguz+D3NwpvhTWBGUSbnygjdzAu8bWiI5TGTMZ7xrisRZ6CBnrTfG0dz QtKeJFoNbwxRQvm/YB3XMOVz/v9P2foVtUkuQcnTb+LKmqpdKQYQ9+3EHqqP1fswM1mT3q 4zL/ObHy1d6DO88i4wj9lymAnXl7kWM= X-Stat-Signature: 8ecneji3y6uhkbhddkn54gxjhzmdqpkg X-Rspamd-Queue-Id: 7F5A7120031 Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of geert@linux-m68k.org has no SPF policy when checking 195.130.132.51) smtp.mailfrom=geert@linux-m68k.org X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1665490565-252334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liam, On Tue, 6 Sep 2022, Liam Howlett wrote: > From: "Liam R. Howlett" > > This is a test suite that uses the radix test infrastructure. It has been > split into its own commit to allow for easier review of the maple tree > code. > > The testing includes: > - Allocation of nodes > - gfp flag allocation checks > - Expansion & contraction of tree > - preallocation checks > - tree navigation by next/prev > - tree navigation by iterators (mas_for_each, etc) > - Number of nodes for a given number of entries > - Generic tree construction tests > - Addition and removal of entries in forward and reverse numerical indexes > - gap searching both forward and reverse > - Combining gaps by overwriting entries in different ways > - splitting right-most node > - splitting left-most node > - overwriting multiple slots > - overwriting across different levels of the tree > - overwriting the middle of a tree > - causing a 3-way split up to the root by overwriting the last slot and > first slot of different nodes and spanning different levels > - RCU stress testing of the tree with threads > - Duplication of the tree by entry count > - Tests which were generated by fuzzers have been added. > - A large number of tests which come from recording crashing in a VM and > reconstructing the tree (see check_erase2_set()) > > Signed-off-by: Liam R. Howlett Thanks for your patch, which is now commit e15e06a8392321a1 ("lib/test_maple_tree: add testing for maple tree"). > --- > lib/test_maple_tree.c | 38307 ++++++++++++++++++++++++++++ Does this test really belong under lib/? All other test modules there can be compiled and run as part of the kernel itself. > tools/testing/radix-tree/Makefile | 9 +- This is for userspace testing? > 2 files changed, 38314 insertions(+), 2 deletions(-) > create mode 100644 lib/test_maple_tree.c Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds