From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0142EECAAD2 for ; Sat, 27 Aug 2022 14:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4775C940008; Sat, 27 Aug 2022 10:33:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42798940007; Sat, 27 Aug 2022 10:33:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE7A940008; Sat, 27 Aug 2022 10:33:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1FA85940007 for ; Sat, 27 Aug 2022 10:33:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E39241201F0 for ; Sat, 27 Aug 2022 14:33:14 +0000 (UTC) X-FDA: 79845615108.04.8254E3C Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf07.hostedemail.com (Postfix) with ESMTP id 42A9740026 for ; Sat, 27 Aug 2022 14:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=Iuq3nK0rNuRuF1gUyF5nWWL/zZs0cy4Nskn16Mkl1pY=; b=YhjS+weSknGI9JQpF4kRNEdx8hTngu1YHh0HEAzk5HRhYgDBxi2Kul+c 51X2ezBicw2NnmXh6J7hbR3UuveQWnDBwkxtZOLvR1cwn54n6IqdglzTL qsg3J4qEIAyzvjiV8ANU2wO9D/j7HlNxncc8cJTFFnSd3wKtCssSQLrjk w=; X-IronPort-AV: E=Sophos;i="5.93,267,1654552800"; d="scan'208";a="22219718" Received: from 16.123.68.85.rev.sfr.net (HELO hadrien) ([85.68.123.16]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2022 16:33:11 +0200 Date: Sat, 27 Aug 2022 16:33:11 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Maxime Ripard cc: Linux Memory Management List , kbuild-all@lists.01.org Subject: [linux-next:master 331/3266] drivers/gpu/drm/vc4/vc4_hdmi.c:1459:2-8: preceding lock on line 1456 (fwd) Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1573044154-1661610791=:6645" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661610793; a=rsa-sha256; cv=none; b=6G5/N3rhq5CCg3TudzsBMD/JShIyEoa/OhmPO2GApQQwpLqjZF++3B28f4c0ncVBQcrg+I N9phWBZ24bicmmY2tS1T37nIzfkomKdSdK/km5ED3OnETQvRdgkbSmKpgrZERCHmxCdztn SS4d/EuOfcf2DsSeMCqhZK+kY5eggVk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=YhjS+weS; spf=pass (imf07.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661610793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Iuq3nK0rNuRuF1gUyF5nWWL/zZs0cy4Nskn16Mkl1pY=; b=Nd77mrSS3+q2IUGsFfqauv+exk/QCeqQ0jK8yLNxEX+o4aCNu6zSABm2nHFCLnGlNmUgvS hVxJrF/RXdXDLb/wgpmEcwUZQK5KQK2plyviMgw8xPRp8d0+iLR4NfJ5fLLtAMH0weJeei aAQmLdvSr9qQHQL/D8F2wtZRPsdj8Rk= X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=YhjS+weS; spf=pass (imf07.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr X-Rspamd-Server: rspam08 X-Stat-Signature: no7imr5xuu7u7iipgqm6obioh3jtzi1s X-Rspamd-Queue-Id: 42A9740026 X-HE-Tag: 1661610793-581409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1573044154-1661610791=:6645 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Please check whether anunlock is needed before line 1459. julia ---------- Forwarded message ---------- Date: Fri, 26 Aug 2022 07:43:10 +0800 From: kernel test robot To: kbuild@lists.01.org Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 331/3266] drivers/gpu/drm/vc4/vc4_hdmi.c:1459:2-8: preceding lock on line 1456 BCC: lkp@intel.com CC: kbuild-all@lists.01.org CC: Linux Memory Management List TO: Maxime Ripard tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b5d939c951865f6fc229094e84b77c9a9e0ed0c7 commit: cd00ed5187bff03d4c2ba143a5993383dd6ed66c [331/3266] drm/vc4: hdmi: Protect device resources after removal :::::: branch date: 18 hours ago :::::: commit date: 6 weeks ago config: arm64-randconfig-c44-20220824 (https://download.01.org/0day-ci/archive/20220826/202208260727.0o3WQ2wp-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Julia Lawall cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/vc4/vc4_hdmi.c:1459:2-8: preceding lock on line 1456 drivers/gpu/drm/vc4/vc4_hdmi.c:1429:2-8: preceding lock on line 1426 vim +1459 drivers/gpu/drm/vc4/vc4_hdmi.c c8b75bca92cbf0 Eric Anholt 2015-03-02 1442 8d9147466776c4 Maxime Ripard 2020-12-15 1443 static void vc4_hdmi_encoder_post_crtc_enable(struct drm_encoder *encoder, 8d9147466776c4 Maxime Ripard 2020-12-15 1444 struct drm_atomic_state *state) 09c438139b8f5b Maxime Ripard 2020-09-03 1445 { 09c438139b8f5b Maxime Ripard 2020-09-03 1446 struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder); cd00ed5187bff0 Maxime Ripard 2022-07-11 1447 struct drm_device *drm = vc4_hdmi->connector.dev; 633be8c3c0c5e0 Maxime Ripard 2021-10-25 1448 struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode; c3c2f38ce532c6 José Expósito 2022-04-20 1449 struct drm_display_info *display = &vc4_hdmi->connector.display_info; 8b3f90e98e1764 Maxime Ripard 2020-09-03 1450 bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC; 8b3f90e98e1764 Maxime Ripard 2020-09-03 1451 bool vsync_pos = mode->flags & DRM_MODE_FLAG_PVSYNC; 81fb55e500a82a Maxime Ripard 2021-10-25 1452 unsigned long flags; 09c438139b8f5b Maxime Ripard 2020-09-03 1453 int ret; cd00ed5187bff0 Maxime Ripard 2022-07-11 1454 int idx; c8b75bca92cbf0 Eric Anholt 2015-03-02 1455 82cb88af12d29e Maxime Ripard 2021-10-25 @1456 mutex_lock(&vc4_hdmi->mutex); 82cb88af12d29e Maxime Ripard 2021-10-25 1457 cd00ed5187bff0 Maxime Ripard 2022-07-11 1458 if (!drm_dev_enter(drm, &idx)) cd00ed5187bff0 Maxime Ripard 2022-07-11 @1459 return; cd00ed5187bff0 Maxime Ripard 2022-07-11 1460 81fb55e500a82a Maxime Ripard 2021-10-25 1461 spin_lock_irqsave(&vc4_hdmi->hw_lock, flags); 81fb55e500a82a Maxime Ripard 2021-10-25 1462 311e305fdb4e82 Maxime Ripard 2020-09-03 1463 HDMI_WRITE(HDMI_VID_CTL, c8b75bca92cbf0 Eric Anholt 2015-03-02 1464 VC4_HD_VID_CTL_ENABLE | 0b066a6809d0f8 Tim Gover 2021-06-28 1465 VC4_HD_VID_CTL_CLRRGB | c8b75bca92cbf0 Eric Anholt 2015-03-02 1466 VC4_HD_VID_CTL_UNDERFLOW_ENABLE | 8b3f90e98e1764 Maxime Ripard 2020-09-03 1467 VC4_HD_VID_CTL_FRAME_COUNTER_RESET | 8b3f90e98e1764 Maxime Ripard 2020-09-03 1468 (vsync_pos ? 0 : VC4_HD_VID_CTL_VSYNC_LOW) | 8b3f90e98e1764 Maxime Ripard 2020-09-03 1469 (hsync_pos ? 0 : VC4_HD_VID_CTL_HSYNC_LOW)); c8b75bca92cbf0 Eric Anholt 2015-03-02 1470 81d830137bdb46 Maxime Ripard 2020-09-03 1471 HDMI_WRITE(HDMI_VID_CTL, 81d830137bdb46 Maxime Ripard 2020-09-03 1472 HDMI_READ(HDMI_VID_CTL) & ~VC4_HD_VID_CTL_BLANKPIX); c8b75bca92cbf0 Eric Anholt 2015-03-02 1473 c3c2f38ce532c6 José Expósito 2022-04-20 1474 if (display->is_hdmi) { 311e305fdb4e82 Maxime Ripard 2020-09-03 1475 HDMI_WRITE(HDMI_SCHEDULER_CONTROL, 311e305fdb4e82 Maxime Ripard 2020-09-03 1476 HDMI_READ(HDMI_SCHEDULER_CONTROL) | c8b75bca92cbf0 Eric Anholt 2015-03-02 1477 VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI); c8b75bca92cbf0 Eric Anholt 2015-03-02 1478 81fb55e500a82a Maxime Ripard 2021-10-25 1479 spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags); 81fb55e500a82a Maxime Ripard 2021-10-25 1480 311e305fdb4e82 Maxime Ripard 2020-09-03 1481 ret = wait_for(HDMI_READ(HDMI_SCHEDULER_CONTROL) & 2b29bf16611a1a Eric Anholt 2016-09-28 1482 VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE, 1000); c8b75bca92cbf0 Eric Anholt 2015-03-02 1483 WARN_ONCE(ret, "Timeout waiting for " c8b75bca92cbf0 Eric Anholt 2015-03-02 1484 "VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n"); c8b75bca92cbf0 Eric Anholt 2015-03-02 1485 } else { 311e305fdb4e82 Maxime Ripard 2020-09-03 1486 HDMI_WRITE(HDMI_RAM_PACKET_CONFIG, 311e305fdb4e82 Maxime Ripard 2020-09-03 1487 HDMI_READ(HDMI_RAM_PACKET_CONFIG) & c8b75bca92cbf0 Eric Anholt 2015-03-02 1488 ~(VC4_HDMI_RAM_PACKET_ENABLE)); 311e305fdb4e82 Maxime Ripard 2020-09-03 1489 HDMI_WRITE(HDMI_SCHEDULER_CONTROL, 311e305fdb4e82 Maxime Ripard 2020-09-03 1490 HDMI_READ(HDMI_SCHEDULER_CONTROL) & c8b75bca92cbf0 Eric Anholt 2015-03-02 1491 ~VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI); c8b75bca92cbf0 Eric Anholt 2015-03-02 1492 81fb55e500a82a Maxime Ripard 2021-10-25 1493 spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags); 81fb55e500a82a Maxime Ripard 2021-10-25 1494 311e305fdb4e82 Maxime Ripard 2020-09-03 1495 ret = wait_for(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) & 2b29bf16611a1a Eric Anholt 2016-09-28 1496 VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE), 1000); c8b75bca92cbf0 Eric Anholt 2015-03-02 1497 WARN_ONCE(ret, "Timeout waiting for " c8b75bca92cbf0 Eric Anholt 2015-03-02 1498 "!VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n"); c8b75bca92cbf0 Eric Anholt 2015-03-02 1499 } c8b75bca92cbf0 Eric Anholt 2015-03-02 1500 c3c2f38ce532c6 José Expósito 2022-04-20 1501 if (display->is_hdmi) { 81fb55e500a82a Maxime Ripard 2021-10-25 1502 spin_lock_irqsave(&vc4_hdmi->hw_lock, flags); 81fb55e500a82a Maxime Ripard 2021-10-25 1503 311e305fdb4e82 Maxime Ripard 2020-09-03 1504 WARN_ON(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) & c8b75bca92cbf0 Eric Anholt 2015-03-02 1505 VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE)); c8b75bca92cbf0 Eric Anholt 2015-03-02 1506 311e305fdb4e82 Maxime Ripard 2020-09-03 1507 HDMI_WRITE(HDMI_RAM_PACKET_CONFIG, 21317b3fba5428 Eric Anholt 2016-09-29 1508 VC4_HDMI_RAM_PACKET_ENABLE); 21317b3fba5428 Eric Anholt 2016-09-29 1509 81fb55e500a82a Maxime Ripard 2021-10-25 1510 spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags); 4ae3d6c09d25a9 Dom Cobley 2022-06-13 1511 vc4_hdmi->packet_ram_enabled = true; 81fb55e500a82a Maxime Ripard 2021-10-25 1512 21317b3fba5428 Eric Anholt 2016-09-29 1513 vc4_hdmi_set_infoframes(encoder); c8b75bca92cbf0 Eric Anholt 2015-03-02 1514 } c8b75bca92cbf0 Eric Anholt 2015-03-02 1515 691456f622a96b Maxime Ripard 2020-09-03 1516 vc4_hdmi_recenter_fifo(vc4_hdmi); c85695a2016e2e Maxime Ripard 2021-05-07 1517 vc4_hdmi_enable_scrambling(encoder); 82cb88af12d29e Maxime Ripard 2021-10-25 1518 cd00ed5187bff0 Maxime Ripard 2022-07-11 1519 drm_dev_exit(idx); 82cb88af12d29e Maxime Ripard 2021-10-25 1520 mutex_unlock(&vc4_hdmi->mutex); c8b75bca92cbf0 Eric Anholt 2015-03-02 1521 } c8b75bca92cbf0 Eric Anholt 2015-03-02 1522 -- 0-DAY CI Kernel Test Service https://01.org/lkp --8323329-1573044154-1661610791=:6645--