From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49675C43334 for ; Mon, 20 Jun 2022 11:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA3866B0073; Mon, 20 Jun 2022 07:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C53BE6B0074; Mon, 20 Jun 2022 07:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1B888E0001; Mon, 20 Jun 2022 07:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A3D706B0073 for ; Mon, 20 Jun 2022 07:57:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 78BBE60D5B for ; Mon, 20 Jun 2022 11:57:38 +0000 (UTC) X-FDA: 79598464596.25.F968A50 Received: from gentwo.de (gentwo.de [161.97.139.209]) by imf23.hostedemail.com (Postfix) with ESMTP id C448714009E for ; Mon, 20 Jun 2022 11:57:37 +0000 (UTC) Received: by gentwo.de (Postfix, from userid 1001) id 3500AB001DF; Mon, 20 Jun 2022 13:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default; t=1655726255; bh=+c4QcA9b5Gi5EsqVv56YKe33xdAr2lQIQbp1pqAYP4g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jO9B1ux7ZEMOyzwGP7zGLGA1rrIbRCZsXlLmhW+4/yKCnEYVIPKCZ5dDIgomx2i5l DplGee1eJbR70onrjgaf6ycP3Zc9TxP/RI6dDmN2DitRZdkb5MVFRZvLVuWAO2EyhK L9MegfCaf2DVrlnH/yPER8zHdz9SCOhnbZJOrRrQrFNhhqojXz9hq2bm5tBcFHr+eu d+5sDtwtNamp2Cjc/Al1LaO/shmFNYjxAaJYn8dmrL0E3nT17RDnj+Cby80ZydmWmR GPSzZtB2JmoxNlPSoI03Ew5+1kw/e+bDcd3KM7mNLXT8QwZyOjJBF+k0ttyAQhMZUL RmXEpYmzqplAA== Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 335F5B00192; Mon, 20 Jun 2022 13:57:35 +0200 (CEST) Date: Mon, 20 Jun 2022 13:57:35 +0200 (CEST) From: Christoph Lameter To: Rongwei Wang cc: David Rientjes , songmuchun@bytedance.com, Hyeonggon Yoo <42.hyeyoo@gmail.com>, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, iamjoonsoo.kim@lge.com, penberg@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/slub: fix the race between validate_slab and slab_free In-Reply-To: <1b434d4c-2a19-9ac1-b2b9-b767b642ec0c@linux.alibaba.com> Message-ID: References: <20220529081535.69275-1-rongwei.wang@linux.alibaba.com> <9794df4f-3ffe-4e99-0810-a1346b139ce8@linux.alibaba.com> <29723aaa-5e28-51d3-7f87-9edf0f7b9c33@linux.alibaba.com> <02298c0e-3293-9deb-f1ed-6d8862f7c349@linux.alibaba.com> <5085437c-adc9-b6a3-dbd8-91dc0856cf19@linux.alibaba.com> <1b434d4c-2a19-9ac1-b2b9-b767b642ec0c@linux.alibaba.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655726258; a=rsa-sha256; cv=none; b=nn2VVNPcGH+YhRhNgnCeZWCHztaTxz31z5i3up2flv8l2/WWLU/w7pepvfiBoA0lm0lUwI 9jJbJgSnBUah5NKMGT1rWWAlx+uov2MC6IpOTjPIuTjVbsachi2UYce967koY1BgGZPCO1 HdKKtX5/ypyIztNdQ0h4UG8eqo61Y7s= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b=jO9B1ux7; dmarc=pass (policy=none) header.from=gentwo.de; spf=pass (imf23.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655726258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+c4QcA9b5Gi5EsqVv56YKe33xdAr2lQIQbp1pqAYP4g=; b=sWGpnLZB6rqoxTehGDdVZG/vO+W2xfvhxAQNiYjnlvjAseuo3bxE0HOdKB1NCn1dU8cjuh KyrV9EvQRZmqLiHhA3MlOQRFKcXRG1EG/MiDt+3hd/R+U3dexsED2gZKUXpWgsHuYF63pY YkEW92Z9pKpfaS6llTlwRHVqQtpZClk= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b=jO9B1ux7; dmarc=pass (policy=none) header.from=gentwo.de; spf=pass (imf23.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de X-Rspam-User: X-Stat-Signature: i7su8auguj1wrxyzfrshpzf8i5fcg71j X-Rspamd-Queue-Id: C448714009E X-Rspamd-Server: rspam08 X-HE-Tag: 1655726257-142732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 18 Jun 2022, Rongwei Wang wrote: > > Well the cycle reduction is strange. Tests are not done in the same > > environment? Maybe good to not use NUMA or bind to the same cpu > It's the same environment. I can sure. And there are four nodes (32G per-node > and 8 cores per-node) in my test environment. whether I need to test in one > node? If right, I can try. Ok in a NUMA environment the memory allocation is randomized on bootup. You may get different numbers after you reboot the system. Try to switch NUMA off. Use s a single node to get consistent numbers. It maybe useful to figure out what memory structure causes the increase in latency in a NUMA environment. If you can figure that out and properly allocate the memory structure that causes the increases in latency then you may be able to increase the performance of the allocator.