From: Julia Lawall <julia.lawall@inria.fr>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: kbuild-all@lists.01.org, lkp@intel.com,
Linux Memory Management List <linux-mm@kvack.org>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm: fix device_node_continue.cocci warnings (fwd)
Date: Sun, 12 Jun 2022 13:02:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2206121300120.3447@hadrien> (raw)
The of_node_put does not seem to be needed. Note that there is none at
the preceeding continues.
julia
---------- Forwarded message ----------
Date: Sat, 11 Jun 2022 06:02:45 +0800
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Cc: lkp@intel.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] drm: fix device_node_continue.cocci warnings
CC: kbuild-all@lists.01.org
BCC: lkp@intel.com
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
CC: Maxime Ripard <mripard@kernel.org>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6d0c806803170f120f8cb97b321de7bd89d3a791
commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller
:::::: branch date: 17 hours ago
:::::: commit date: 31 hours ago
Please take the patch only if it's a positive warning. Thanks!
drivers/gpu/drm/logicvc/logicvc_layer.c | 2 --
1 file changed, 2 deletions(-)
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d
ret = logicvc_layer_init(logicvc, layer_node, index);
if (ret)
goto error;
-
- of_node_put(layer_node);
}
of_node_put(layers_node);
next reply other threads:[~2022-06-12 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 11:02 Julia Lawall [this message]
2022-06-24 15:08 ` Paul Kocialkowski
2022-06-24 15:26 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2206121300120.3447@hadrien \
--to=julia.lawall@inria.fr \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox