From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F55C43334 for ; Thu, 9 Jun 2022 11:58:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ADF18D0007; Thu, 9 Jun 2022 07:58:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65E548D0006; Thu, 9 Jun 2022 07:58:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525E98D0007; Thu, 9 Jun 2022 07:58:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 42A698D0006 for ; Thu, 9 Jun 2022 07:58:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1B7D160EBC for ; Thu, 9 Jun 2022 11:58:50 +0000 (UTC) X-FDA: 79558550820.08.79D4E95 Received: from gentwo.de (gentwo.de [161.97.139.209]) by imf09.hostedemail.com (Postfix) with ESMTP id 456B2140074 for ; Thu, 9 Jun 2022 11:58:49 +0000 (UTC) Received: by gentwo.de (Postfix, from userid 1001) id 0CDE7B00149; Thu, 9 Jun 2022 13:58:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default; t=1654775927; bh=NzmzzhGPGUY7xZcOQ+0OfmkAMUDNRFa2wttp68Yz7bk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mDV8x/vOv68VDjg22k4RMOhgEUyQVhp17be0H3abpHmpzRHLZ6eO0kdAts6i3K9nY /EiGmDVD0hGP/O4Pi+KdVjBAFkYec4qnTpSaNfOhGMLZRGtbGgwRwdqWQSGCP+UJ4s DXp63jvxADrXo3v/B15z140CcV7ptnfpj7f5q+cLQx7j9KPrJc0O06VLtRDDSTiSXs AXGOtstnavFqll3La/hP6p6Df1tSar0ioozucIOfyORzOOuStcR7kYuGcV9q7t+vZi OIAKhJHOuzd+Fe8hRfR2IMAOD+ZzafeFSvO9XR9dBgVI7twEF6uV/hT0Cko/PDQTGN uVtkXOkrMGKrQ== Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 0B516B0012F; Thu, 9 Jun 2022 13:58:47 +0200 (CEST) Date: Thu, 9 Jun 2022 13:58:47 +0200 (CEST) From: Christoph Lameter To: Jann Horn cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: add missing TID updates on slab deactivation In-Reply-To: <20220608182205.2945720-1-jannh@google.com> Message-ID: References: <20220608182205.2945720-1-jannh@google.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654775929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzmzzhGPGUY7xZcOQ+0OfmkAMUDNRFa2wttp68Yz7bk=; b=4VbPew9HIIaUZnKXP/73FvfA3OfGHpiE5cVQnPUfVxU6fa1OxBtxsstZoZkJA3nqbfaMos 9fNZso690o+R35fyznWtoQzAlGcagC3JdKLeGlP2dECjOqDBofMcmjmnqCEd4T0GIYxv1k OmZcuun0BrNGJUYgZ2yhHQb6h5lVjZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654775929; a=rsa-sha256; cv=none; b=4JO/E25pn2wCZWmSHoITyr+St5F43LX6LVGkQsqb/JY+81BIRYYwxa4DLO4jB/M4zYq0sQ Vavgh/JA+moOPnT9TLhvr6KsnnxtboN2D/8BuYaMIVvWcAwJMOFfqt79hfYIheDtGaHAhn h2enx537WKF3cw+X/b4kMZ6UcrMgLJI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b="mDV8x/vO"; dmarc=pass (policy=none) header.from=gentwo.de; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b="mDV8x/vO"; dmarc=pass (policy=none) header.from=gentwo.de; spf=pass (imf09.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: 8bi9hgoocbs7c376k37yokdp4eprmpjf X-Rspamd-Queue-Id: 456B2140074 X-HE-Tag: 1654775929-575114 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Jun 2022, Jann Horn wrote: > The fastpath in slab_alloc_node() assumes that c->slab is stable as long as > the TID stays the same. However, two places in __slab_alloc() currently > don't update the TID when deactivating the CPU slab. Looks ok. Acked-by: Christoph Lameter