From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C808C433F5 for ; Fri, 29 Apr 2022 07:32:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B84C6B0071; Fri, 29 Apr 2022 03:32:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7671D6B0073; Fri, 29 Apr 2022 03:32:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6567D6B0074; Fri, 29 Apr 2022 03:32:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 5682A6B0071 for ; Fri, 29 Apr 2022 03:32:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 22C838138A for ; Fri, 29 Apr 2022 07:32:24 +0000 (UTC) X-FDA: 79409098608.25.54646B7 Received: from gentwo.de (gentwo.de [161.97.139.209]) by imf27.hostedemail.com (Postfix) with ESMTP id D24BB4005A for ; Fri, 29 Apr 2022 07:32:21 +0000 (UTC) Received: by gentwo.de (Postfix, from userid 1001) id 1AC78B00482; Fri, 29 Apr 2022 09:32:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default; t=1651217541; bh=F2FSC0hRsA8+n019LPklPzknF+AllKhEx1dZ7N/lS1I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ruOivHidCS4FDrYYnhBEJ9lBinlWDO0c+g0CSH6FBl5PiaaeHEEC6yXiYfvfbomY0 C62qJSB1h5UU5wmnrhM1kfHYNYiYuNtlahdLg1PcX0jVqkCsV5BbbX8DxEcP07L+Oc sq8x2VbJzHOUtxA+8D1fPX2QjNn8HKKOrs24AFERi3YOkTrwMQ4akgbjj6mQyx7sE+ qRvMD0Y/L78XE/Lk6Q0M+961wBOBcm470aHMbcQIp5Y7ToMNh9Z3AHt4eXCxQUeE3G 3yNmq1WY1eCgV7jFL974N1KDQPmf5uhqfblBBFhoQolyfPnfwOsU47qPeWM3PtL9jB lDsV5l5+h9Lpw== Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 1983CB00127; Fri, 29 Apr 2022 09:32:21 +0200 (CEST) Date: Fri, 29 Apr 2022 09:32:21 +0200 (CEST) From: Christoph Lameter To: andrey.konovalov@linux.dev cc: Andrew Morton , Andrey Konovalov , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Peter Collingbourne , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 1/2] mm: slab: fix comment for ARCH_KMALLOC_MINALIGN In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: yr3swnjihsdnehkz46s9gty1kf96opuj X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D24BB4005A Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gentwo.de header.s=default header.b=ruOivHid; spf=pass (imf27.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de; dmarc=pass (policy=none) header.from=gentwo.de X-Rspam-User: X-HE-Tag: 1651217541-338917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 28 Apr 2022, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > The comment next to the ARCH_KMALLOC_MINALIGN definition says that > ARCH_KMALLOC_MINALIGN can be defined in arch headers. This is incorrect: > it's actually ARCH_DMA_MINALIGN that can be defined there. The section is talking about kmalloc and not general kmem_cache_alloc() and there was the intention of separating the alignment requirements between these two groups of caches in the slab allocators.