From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E937DC433EF for ; Thu, 14 Apr 2022 09:58:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DF946B0071; Thu, 14 Apr 2022 05:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 768F56B0073; Thu, 14 Apr 2022 05:58:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 631276B0074; Thu, 14 Apr 2022 05:58:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 4FFA26B0071 for ; Thu, 14 Apr 2022 05:58:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 22AC72A56 for ; Thu, 14 Apr 2022 09:58:04 +0000 (UTC) X-FDA: 79355033688.08.F3528B7 Received: from gentwo.de (gentwo.de [161.97.139.209]) by imf30.hostedemail.com (Postfix) with ESMTP id 6873C8000A for ; Thu, 14 Apr 2022 09:58:03 +0000 (UTC) Received: by gentwo.de (Postfix, from userid 1001) id 592E6B002FC; Thu, 14 Apr 2022 11:58:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by gentwo.de (Postfix) with ESMTP id 57F2BB00268; Thu, 14 Apr 2022 11:58:01 +0200 (CEST) Date: Thu, 14 Apr 2022 11:58:01 +0200 (CEST) From: Christoph Lameter To: Hyeonggon Yoo <42.hyeyoo@gmail.com> cc: Vlastimil Babka , Marco Elver , Matthew WilCox , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 23/23] mm/sl[au]b: check if large object is valid in __ksize() In-Reply-To: <20220414085727.643099-24-42.hyeyoo@gmail.com> Message-ID: References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-24-42.hyeyoo@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: 1qjguriupbhfru5w6nk9fqeatiuip5is X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6873C8000A Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de; dmarc=none X-Rspam-User: X-HE-Tag: 1649930283-156122 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Apr 2022, Hyeonggon Yoo wrote: > If address of large object is not beginning of folio or size of > the folio is too small, it must be invalid. Return zero in such cases. This looks like a slab usage error on the part of the caller that would benefit from a kernel log entry. A warning or an error?