From: Christoph Lameter <cl@linux.com>
To: Abel Wu <abel.w@icloud.com>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
hewenliang4@huawei.com, wuyun.wu@huawei.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: embed __slab_alloc to its caller
Date: Tue, 2 Feb 2021 10:11:53 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2102021009470.50959@www.lameter.com> (raw)
In-Reply-To: <20210202080515.2689-1-abel.w@icloud.com>
On Tue, 2 Feb 2021, Abel Wu wrote:
> Since slab_alloc_node() is the only caller of __slab_alloc(), embed
> __slab_alloc() to its caller to save function call overhead. This
> will also expand the caller's code block size a bit, but hackbench
> tests on both host and guest didn't show a difference w/ or w/o
> this patch.
slab_alloc_node is an always_inline function. It is intentional that only
the fast path was inlined and not the slow path.
next prev parent reply other threads:[~2021-02-02 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:05 Abel Wu
2021-02-02 10:11 ` Christoph Lameter [this message]
2021-02-03 1:41 ` Abel Wu
2021-02-05 13:03 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2102021009470.50959@www.lameter.com \
--to=cl@linux.com \
--cc=abel.w@icloud.com \
--cc=akpm@linux-foundation.org \
--cc=hewenliang4@huawei.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox